Comment 12 for bug 137598

Revision history for this message
Tim Hull (thully) wrote : Re: [Bug 137598] Re: Screen brightness resets to default (maximum) on idle with AC plugged in

Yes - fixing that would require a "previous brightness" variable in the
code. It would basically be checked, and then the brightness code would
take it into account when exiting idle.

I figure the best way to fix all these brightness problems would be to:

1. Do not use "idle" events when idle_on_ac is disabled on AC (or
idle_on_batt on battery).
2. Store a "previous brightness" in the backlight struct and revert to this
when we update the brightness to return from a dimmed state.
3. Check if brightness is less than idle brightness before dimming. If it
is, leave it alone.

If these three things are implemented, the brightness logic should be
working as expected. My other patches fix the problems, but this seems like
a more ideal way to do it.

I may take a look, but I can't guarantee anything. I hope the devs get a
patch committeed 7.10 final - this is a big regression for laptop users,
and something that would probably be noticed by most users/reviewers on
laptops.

On 10/4/07, Simon Ruggier <email address hidden> wrote:
>
> The problem with idle dimming enabled would be when the user stops being
> idle. The brightness would be "reset" to whatever g-p-m thinks the
> brightness is (100% by default), instead of what it was actually set to
> using the fn keys.
>
> --
> Screen brightness resets to default (maximum) on idle with AC plugged in
> https://bugs.launchpad.net/bugs/137598
> You received this bug notification because you are a direct subscriber
> of the bug.
>