Comment 10 for bug 998521

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

This is a huge diff, not just "a few minor changes" IMO. Its sort of shocking that glib adds so much in a a few "patch" releases. I know some of these things are for non-Linux platforms, but its really quite hard to separate them out.

If this is just a one line fix, why aren't we just cherry picking the one line fix for this bug? Thats typically how we control regression potential. I'm digging through the diff (34,000 lines!) but at this point I can't really justify the time to review it all.

Can somebody update the test case to include a comprehensive test plan so we can get enough test coverage, or re-upload with just the fix for this bug?