Comment 18 for bug 212491

Revision history for this message
Shlomil (shlomister) wrote :

hi,

1. I Committed a branch called "hebrew-fix" using bzr in my own user branches. I could not commit it under ubuntu-core-dev. I guess I don't have the permissions to do so:

$ bzr push sftp://<email address hidden>/~ubuntu-core-dev/gfxboot-theme-ubuntu/hebrew-fix
bzr: ERROR: Permission denied: "/~ubuntu-core-dev/gfxboot-theme-ubuntu/hebrew-fix": [Errno 13] mkdir failed
$ bzr push sftp://<email address hidden>/~shlomister/gfxboot-theme-ubuntu/hebrew-fix
Created new branch.

Is that OK? Can you merge it like this?

2. Used LP: ##### form this time.

3. Not sure it works as well for Arabic (I know some basics of the language but not enough to be a tester) so for now I will only apply the patch for Hebrew.

4. You are right... I forgot I have to use 'eq' - my perl skills are a little rusty.

5. You are right .. again - passing these strings in shell in not secure nor stable. I changed it to use open2. There are no trailing newlines to fiddle with but, as you might have noticed in my first patch, the bidi algorithm converts C format string parameters from %s to s% and that is fixed by that little additional regex over there.

Thanks for the comments and guidance.