Comment 12 for bug 1958162

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Jammy verification

Reproducing the problem with the release package:
frr:
  Installed: 8.1-1ubuntu1
  Candidate: 8.1-1ubuntu1
  Version table:
 *** 8.1-1ubuntu1 500
        500 http://br.archive.ubuntu.com/ubuntu jammy/main amd64 Packages

Right after install, /var/log/frr is empty even after a restart, and ownership is frr:frr:
root@jammy-frr-logging:~# systemctl restart frr
root@jammy-frr-logging:~# ls -la /var/log/frr
total 0
drwxr-x--- 1 frr frr 0 Mar 11 12:33 .
drwxrwxr-x 1 root syslog 256 Aug 15 12:58 ..
root@jammy-frr-logging:~#

And there is a permission denied error in syslog:
root@jammy-frr-logging:~# grep frr\\.log /var/log/syslog
Aug 15 12:59:49 jammy-frr-logging rsyslogd: file '/var/log/frr/frr.log': open error: Permission denied [v8.2112.0 try https://www.rsyslog.com/e/2433 ]

1) upgrade test

Updating to proposed:
root@jammy-frr-logging:~# apt-cache policy frr
frr:
  Installed: 8.1-1ubuntu1.1
  Candidate: 8.1-1ubuntu1.1
  Version table:
 *** 8.1-1ubuntu1.1 500
        500 http://br.archive.ubuntu.com/ubuntu jammy-proposed/main amd64 Packages

a) right after the upgrade, /var/log/frr is now correctly owned by syslog:adm:
root@jammy-frr-logging:~# ls -lad /var/log/frr
drwxr-x--- 1 syslog adm 0 Mar 11 12:33 /var/log/frr

b) an frr restart creates the log file finally, owned by syslog:adm:
root@jammy-frr-logging:~# ls -la /var/log/frr
total 0
drwxr-x--- 1 syslog adm 0 Mar 11 12:33 .
drwxrwxr-x 1 root syslog 256 Aug 15 12:58 ..
root@jammy-frr-logging:~# systemctl restart frr
root@jammy-frr-logging:~# ls -la /var/log/frr
total 4
drwxr-x--- 1 syslog adm 14 Aug 15 13:03 .
drwxrwxr-x 1 root syslog 256 Aug 15 12:58 ..
-rw-r----- 1 syslog adm 1379 Aug 15 13:03 frr.log

c) logrotate works, and preserves permissions:
root@jammy-frr-logging:~# ls -la /var/log/frr
total 4
drwxr-x--- 1 syslog adm 14 Aug 15 13:03 .
drwxrwxr-x 1 root syslog 256 Aug 15 12:58 ..
-rw-r----- 1 syslog adm 1379 Aug 15 13:03 frr.log
root@jammy-frr-logging:~#
root@jammy-frr-logging:~#
root@jammy-frr-logging:~#
root@jammy-frr-logging:~# ls -la /var/log/frr
total 4
drwxr-x--- 1 syslog adm 14 Aug 15 13:03 .
drwxrwxr-x 1 root syslog 256 Aug 15 12:58 ..
-rw-r----- 1 syslog adm 1379 Aug 15 13:03 frr.log
root@jammy-frr-logging:~# logrotate -f /etc/logrotate.conf
root@jammy-frr-logging:~# ls -la /var/log/frr
total 4
drwxr-x--- 1 syslog adm 38 Aug 15 13:03 .
drwxrwxr-x 1 root syslog 336 Aug 15 13:03 ..
-rw-r----- 1 syslog adm 0 Aug 15 13:03 frr.log
-rw-r----- 1 syslog adm 507 Aug 15 13:03 frr.log.1.gz

Upgrade test succeeded.

2) Fresh install test
root@jammy-frr-logging-fresh-install:~# apt-cache policy frr
frr:
  Installed: 8.1-1ubuntu1.1
  Candidate: 8.1-1ubuntu1.1
  Version table:
 *** 8.1-1ubuntu1.1 500
        500 http://br.archive.ubuntu.com/ubuntu jammy-proposed/main amd64 Packages

Ownership of /var/log/frr is correct from the start (syslog:adm):
root@jammy-frr-logging-fresh-install:~# ls -lad /var/log/frr
drwxr-x--- 1 syslog adm 0 Jul 19 20:36 /var/log/frr

After a restart, frr is ably to produce its log file via rsyslogd with correct ownership:
root@jammy-frr-logging-fresh-install:~# systemctl restart frr
root@jammy-frr-logging-fresh-install:~# ls -la /var/log/frr
total 4
drwxr-x--- 1 syslog adm 14 Aug 15 13:10 .
drwxrwxr-x 1 root syslog 256 Aug 15 13:09 ..
-rw-r----- 1 syslog adm 1561 Aug 15 13:10 frr.log

And logrotate is also happy:
root@jammy-frr-logging-fresh-install:~# ls -la /var/log/frr
total 4
drwxr-x--- 1 syslog adm 14 Aug 15 13:10 .
drwxrwxr-x 1 root syslog 256 Aug 15 13:09 ..
-rw-r----- 1 syslog adm 1561 Aug 15 13:10 frr.log
root@jammy-frr-logging-fresh-install:~# logrotate -f /etc/logrotate.conf
root@jammy-frr-logging-fresh-install:~# ls -la /var/log/frr
total 4
drwxr-x--- 1 syslog adm 38 Aug 15 13:11 .
drwxrwxr-x 1 root syslog 336 Aug 15 13:11 ..
-rw-r----- 1 syslog adm 0 Aug 15 13:11 frr.log
-rw-r----- 1 syslog adm 518 Aug 15 13:10 frr.log.1.gz

Fresh install test succeeded.

Jammy verification succeeded.