Comment 19 for bug 694413

Thanks for trying fix, but still some issues:

1) Please avoid unnecessary changes in debian/changelog like:

   * New upstream release (closes: #284109)
@@ -192,7 +431,7 @@
     firestarter) is incompatible with /etc/ppp/ip-up.d/1firestarter.

  -- Yann Verley <email address hidden> Wed, 28 Nov 2004 22:23:07 +0100
-
+
 firestarter (0.9.3-6) unstable; urgency=low

   * adopting orphaned package.
@@ -454,0 +694 @@
+

You can see it in debdiff debian-ubuntu.

2) You added 2 patches, 23 and 24, but these are not a part of remaining changes so should be mentioned in separate star like dropped changes. Please forward them to Debian and upstream.

3) Please use better describe of change in debian/control. In future please research older entries in debian/changelog or Bazaar. I found following: "Replace gksu dependency with menu to ensure that su-to-root is available." (http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/natty/firestarter/natty/revision/23)

4) Also debian/watch is described incorrect. Below remaining changes is a place for describe why change has been added. "Added from previous Ubuntu changes" is not a reason. I know that last uploader wasn't too talkative, so you can use "Added for uscan." Please forward it to Debian.

5) Please fix this change in debian/patches/00list:
-21_locales_failing
-22_remove_encoding_from_desktop
+21_locales_failing.dpatch
+22_remove_encoding_from_desktop.dpatch
You shouldn't touch it since it's not our delta. Keep patch filenames from Debian source.

6) Fix DEP3 tags in your patches. It should like in example: http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/maverick/lcms/maverick-updates/revision/18#debian/patches/CVE-2009-0793.dpatch

7) If you have forwarded changes, please add to debian/changelog (Closes: #XXXXXX) as well.