Comment on attachment 572525 patch
Review of attachment 572525: -----------------------------------------------------------------
With this patch I can't compile.
we need to add access to the dbus headers in accessible/src/base/Makefile.in
::: accessible/src/base/nsAccessibilityService.cpp @@ +1837,5 @@ > //////////////////////////////////////////////////////////////////////////////// > > +namespace mozilla { > +namespace a11y { > + mozilla::a11y::FocusManager*
We should remove the namespace qualifier here since we are inside it.
@@ +1842,1 @@ > mozilla::a11y::FocusMgr()
and here
@@ +1842,5 @@ > mozilla::a11y::FocusMgr() > { > return nsAccessibilityService::gAccessibilityService; > } > +
We are missing } }
to close the namespaces above.
Comment on attachment 572525
patch
Review of attachment 572525: ------- ------- ------- ------- ------- ------- ------- ------- --
-------
With this patch I can't compile.
we need to add access to the dbus headers in accessible/ src/base/ Makefile. in
::: accessible/ src/base/ nsAccessibility Service. cpp /////// /////// /////// /////// /////// /////// /////// /////// /////// /////// /// :a11y:: FocusManager*
@@ +1837,5 @@
> ///////
>
> +namespace mozilla {
> +namespace a11y {
> + mozilla:
We should remove the namespace qualifier here since we are inside it.
@@ +1842,1 @@ :a11y:: FocusMgr( )
> mozilla:
and here
@@ +1842,5 @@ :a11y:: FocusMgr( ) Service: :gAccessibility Service;
> mozilla:
> {
> return nsAccessibility
> }
> +
We are missing
}
}
to close the namespaces above.