Comment 10 for bug 1998678

The separate topic I mentioned, which seems to be an unrelated side issues, is that I notice --identity appears to be duplicated in our template:

    condition = ${run{/usr/bin/spfquery.mail-spf-perl --ip \
                   ${quote:$sender_host_address} --identity \
                   ${if def:sender_address_domain \
                       {--scope mfrom --identity ${quote:$sender_address}}\
                       {--scope helo --identity ${quote:$sender_helo_name}}}}\
                   {no}{${if eq {$runrc}{1}{yes}{no}}}}

Thomas stripped that down to this valid code, which he found ran correctly (I did similarly and also confirm it works):

    condition = ${run{/usr/bin/spfquery.mail-spf-perl --ip \
                     $sender_host_address --identity \
                     --scope mfrom --identity sender_address}\
                     {no}{${if eq {$runrc}{1}{yes}{no}}}}

From `spfquery.mail-spf-perl --help` it looks like --identity expects an argument and appears intended to be used just once so I'm guessing the first --identity there is a stray typo. It doesn't seem to cause any problems, but am I correct that it shouldn't be there to begin with?