Comment 12 for bug 1991564

Revision history for this message
Bryce Harrington (bryce) wrote :

The fixes included in 2.3.17.1 are given by this range, and summarized below:

    https://github.com/dovecot/core/compare/2.3.17...2.3.17.1

1. lib-ssl-iostream: Fix assert-crash when OpenSSL returns syscall error
  -> Fixes regression caused by f41874b

2. dsync: Add back missing -T parameter
  -> Fixes regression caused by 5676c51

3. lib-master: Add MASTER_SERVICE_FLAG_DISABLE_SSL_SET
  master: Use MASTER_SERVICE_FLAG_DISABLE_SSL_SET
  -> Fixes regression caused by 36ff43f (***)

4. dsync: Add back various missing parameters
  -> Fixes regression caused by 5676c51

5. man: Add missing parameters to doveadm-sync

6. dsync: Fix -I max-size to actually be the max-size rather than min-size

For reference, here are the commits for the changes this branch introduces:

    https://github.com/dovecot/core/compare/77dd654...368a967

79a210c1f7e94a1863f17db0b9f14b6d3c89e15f
c6cea575772189495a612d4e55f207a2d5009db2
a7fb3cce6a6048e52ce657f9085d54b24bc8a28d
36ff43f1a9aff8594d08f791e77ea13390fd569f (***)
368a96783e8a64a62d07da4adcf2f3b1b525380b

This indicates that at least the two commits from item (3) in 2.3.17.1 relates to the changes included in this branch. Note that the affected commit, 36ff43f, is not one of the refactoring changes but is rather the fix itself that this branch seeks to integrate.

I did not find a bug report for this fix, however the related discussion appears to be this thread:

    https://www.mail-archive.com/search?<email address hidden>&q=subject:%22Re%5C%3A+2.3.17+broken+on+CentOS8+%5C%2F+bug%22&o=newest&f=1

The commit includes a comment that describes the problem being solved by the added option:

        /* Don't read any SSL settings. This is mainly needed to prevent master
    process from trying to pass through huge list of SSL CA certificates
    through environment for ssl_ca setting, which could fail. Although
    the same problem can still happen with standalone doveadm if it
    reads settings via doveconf instead of config socket. */