Comment 2 for bug 1588479

Revision history for this message
Brian Murray (brian-murray) wrote : Re: dkms_packages.py supported kernel check seems wrong

Well, it changed in 2012...

 $ bzr log -r 1369.34.701 -p
------------------------------------------------------------
revno: 1369.34.701
committer: Martin Pitt <email address hidden>
branch nick: apport
timestamp: Tue 2012-09-18 12:12:33 +0200
message:
  * packaging-apt-dpkg.py: When throwing ValueErrors, show the non-existing package name. This makes it easier to debug such crashes.
diff:
=== modified file 'NEWS'
--- NEWS 2012-09-18 09:15:59 +0000
+++ NEWS 2012-09-18 10:12:33 +0000
@@ -4,6 +4,8 @@
 2.5.3 (UNRELEASED):
 -------------------
  * data/apportcheckresume: Open report file in binary mode. (LP: #1040353)
+ * packaging-apt-dpkg.py: When throwing ValueErrors, show the non-existing
+ package name. This makes it easier to debug such crashes.

 2.5.2 (2012-09-17):
 -------------------

=== modified file 'backends/packaging-apt-dpkg.py'
--- backends/packaging-apt-dpkg.py 2012-08-24 05:27:31 +0000
+++ backends/packaging-apt-dpkg.py 2012-09-18 10:12:33 +0000
@@ -112,7 +112,7 @@
         try:
             return self._cache()[package]
         except KeyError:
- raise ValueError('package does not exist')
+ raise ValueError('package %s does not exist' % package)

     def get_version(self, package):
         '''Return the installed version of a package.'''
@@ -120,7 +120,7 @@
         pkg = self._apt_pkg(package)
         inst = pkg.installed
         if not inst:
- raise ValueError('package does not exist')
+ raise ValueError('package %s does not exist' % package)
         return inst.version

     def get_available_version(self, package):