- Uses dbus-glib, should be ported to gdbus at some point.
- cups-pk-helper-mechanism.c is by and large boilerplate code and looks correct to me. The polkit result is properly checked, and there are no complicated memory operations.
- cups.c is rather large, but also pretty straightforward code to translate the dbus interface to the libcups API; it does some rather thorough input value validity checks.
- uses gettext properly
- Good maintenance in Debian so far, although the package is only half a year old; no bug reports
- No Ubuntu bugs, but not surprising as the package hasn't been used by default
- straightforward packaging
Things that caught my eye during review:
- Uses dbus-glib, should be ported to gdbus at some point. helper- mechanism. c is by and large boilerplate code and looks correct to me. The polkit result is properly checked, and there are no complicated memory operations.
- cups-pk-
- cups.c is rather large, but also pretty straightforward code to translate the dbus interface to the libcups API; it does some rather thorough input value validity checks.
- uses gettext properly
- Good maintenance in Debian so far, although the package is only half a year old; no bug reports
- No Ubuntu bugs, but not surprising as the package hasn't been used by default
- straightforward packaging