Comment 8 for bug 541990

Hi Martin,

On Mar 29, 2010, at 06:37 AM, Martin Pitt wrote:

>- Did that change any of the logic about which packages are considered
>- "cruft"?

I did not. All of that lives inside the computerjanitor Python package, which
actually lives in Update Manager source package. I haven't touched any of
that code for CJ 2.0.

>- Can you please attach a branch/patch for this, for a quick review?

A patch will be huge. The changes have already been merged into the c-j
trunk and are visible here:

http://bazaar.launchpad.net/~computer-janitor-hackers/computer-janitor/trunk/changes/224?start_revid=224

though there have been a few small changes applied after that.

>- Does it change any user-visible strings/break translations?

Yes, it does change some user visible strings.

>- How does the frontend behave if the backend crashes? (Throwing DBusExceptions is a common phenomenon with dbus service backed programs, and hard to get right)

Yes, the front-end currently throws DBusExceptions. What should it do instead?

>This is a pretty bold change for this point in the release cycle, and
>TBH I'm not really happy about this now. While 2.x might have its known
>problems, we at least know where we are with it, and it'd seem more
>prudent to fix a few bugs in that version than changing the entire
>architecture?

I totally understand wanting to be conservative about this application!
However the threading problems are just not feasible to fix separately, which
is why the dbus refactoring was undertaken to make the front-ends single
threaded.

-Barry