Comment 16 for bug 180624

Revision history for this message
Loïc Minier (lool) wrote :

@Mantas: nice update; here's a review:

1) I see you updated the -good dependency, could you do the same with the other dependencies mentioned in the README like e.g. gstreamer-base and any other?

2) Concerning the fix_desktop patch, could you please mention its update in the changelog?

3) Here's a summary of what the hildon patch does and which should be ported to the new build system:
a) adds a ./configure flag to allow building with hildon support; this flag will set WITH_HILDON=1 and check for the hildon-1 pkg-config file
b) add a data/cheese.hildon.glade file
c) change data/Makefile to use HILDONFILE (set to cheese.hildon.glade) for GLADEFILE if WITH_HILDON is set, and to ship that file
d) change src/cheese-fileutil.c to use "%s/Mydocs/.images/" instead of "%s/.gnome2/cheese/%s" for the image path if WITH_HILDON is set
e) change src/cheese-window.c to create a hildon window instead of a gtk window and use the proper glade filename if WITH_HILDON is set
f) change src/Makefile to add HILDON_CFLAGS and HILDON_LIBS to CFLAGS and LIBS if WITH_HILDON is set

It's likely that the a, c, and f changes blow up and need to be ported to autotools; the other changes you should be able to port; could you prepare an updated patch for this part and tell me whether you need help for autotools or for the other changes?

Thanks!