Comment 96 for bug 752881

Revision history for this message
Daniel Manrique (roadmr) wrote :

Thanks for the report, the script is very outdated and it's just not working anymore, first the dbus method fails to suspend the system (this is around line 140 of the script), but even if I change that to use pm-suspend, the loop starting around line 157 is suspect and fails to find the expected string indicating resume is complete ("Back to C"). Looking at output from a recent (3.8.0) kernel it doesn't even print that string anymore.

I checked and there are no checkbox jobs using this script anymore, which leads me to believe we stopped using it at some point but neglected removing it.

My recommendation would be removing the script from Checkbox entirely, as it's broken due to bitrot.

Carla, would you be OK with this approach? to clarify, checkbox has newer and better fwts-based suspend tests (see suspend/suspend_advanced), so we do provide for testing this functionality, just not with the old script.

I'll set to triaged but wait for the original reporter's opinion before pulling the trigger on any changes.