Comment 5 for bug 752503

Revision history for this message
Luke Yelavich (themuso) wrote : Re: [Bug 752503] Re: [Natty or perhaps Ocelot] Please enable default the caret navigation mode for Yelp application with all blindness related profiles

Thanks very much for your patch, I have reviewed it, and tweaked it slightly, and uploaded it. A few comments:

1. You don't need to comment what the code is doing in such great detail. If the code is relatively simple, reading the code alone should be explanation enough as to what it does. The only time I tend to use comments is if I want to tell the reader that what follows is complicated, and explanation of the logic is needed, or, that something needs fixing, or that its an ugly hack. :)
2. I still don't agree that when a new user creates an account, that they will want carrot navigation enabled by default, because they may wish to use the arrow keys to move through the document. We don't enable accessibility by default for any new user creating an acount, so I don't see a reason for the yelp carrot navigation mode being enabled, just because accessibility isn't.

I do understand your point of view regarding this matter, and longer term, I think we need a good accessible control panel application that allows people to tweak these settings for their account, and/or newly created user accounts.

Thanks again.