Comment 129 for bug 284994

Revision history for this message
tz (thomas-mich) wrote : Re: [Bug 284994] Re: bluetooth-wizard unable to pair to fixed pin devices

I think the only change would be to the maximum length (change 4 to 16
with the ////... line):

+ hbox_custom = gtk_hbox_new(FALSE, 6);
+ radio_custom =
gtk_radio_button_new_with_label_from_widget(GTK_RADIO_BUTTON(radio_0000),
_("Custom PIN code:"));
+ entry_custom = gtk_entry_new_with_max_length(4);
///////////////////////////////////////////////////////////////////////
+ gtk_entry_set_width_chars(GTK_ENTRY(entry_custom), 4);
+ g_signal_connect (entry_custom, "key-press-event",
+ G_CALLBACK (entry_custom_event), NULL);
+ g_signal_connect (entry_custom, "changed",
+ G_CALLBACK (entry_custom_changed), NULL);
+ gtk_box_pack_start(GTK_BOX(hbox_custom), radio_custom,
+ FALSE, FALSE, 0);
+ gtk_box_pack_start(GTK_BOX(hbox_custom), entry_custom,
+ FALSE, FALSE, 0);
+ gtk_container_add(GTK_CONTAINER(vbox_fixed), hbox_custom);

I'll file a separate bug, but this goes to one of the original
problems that short pincodes are insecure and they didn't allow
options for longer ones.

On Mon, Mar 16, 2009 at 12:02 PM, Martin Pitt <email address hidden> wrote:
> tz: The patch is attached to the upstream bug linked here:
> http://bugzilla.gnome.org/attachment.cgi?id=127898&action=view
>
> If you think that the pin length is a real issue, please open a separate
> bug. The fixed length 4 is used in several places in the code, and it's
> not an obvious and trivial change, so it should be tracked
> appropriately. Thanks!
>
> --
> bluetooth-wizard unable to pair to fixed pin devices
> https://bugs.launchpad.net/bugs/284994
> You received this bug notification because you are a direct subscriber
> of the bug.
>