Comment 8 for bug 1491406

Revision history for this message
Robie Basak (racb) wrote :

Uploaded, thanks Ryan. A couple of comments:

I tweaked your dep3 headers as follows. Last-Updated is defined as being hyphenated, and AIUI "Origin: upstream, ..." is appropriate for when the patch is cherry-picked from upstream, as opposed to "Applied-Upstream: ..." which is for when the patch is going in the other direction. So I did:

--- augeas-lenses-nagioscfg-nospace.patch.orig 2016-06-08 14:18:44.675981037 +0000
+++ augeas-lenses-nagioscfg-nospace.patch 2016-06-08 14:19:12.844037262 +0000
@@ -2,10 +2,9 @@
  Subject: [PATCH] NagiosCfg: default to no spaces around equal, fix #177

 Author: =?UTF-8?q?Rapha=C3=ABl=20Pinson?= <email address hidden>
-Origin: https://github.com/hercules-team/augeas/commit/b0add7511ca43b03e57baffd17cfd8d77442849f.patch
+Origin: upstream, https://github.com/hercules-team/augeas/commit/b0add7511ca43b03e57baffd17cfd8d77442849f.patch
 Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/augeas/+bug/1491406
-Applied-Upstream: https://github.com/hercules-team/augeas/commit/b0add7511ca43b03e57baffd17cfd8d77442849f.patch
-Last-Update: 20160607
+Last-Update: 2016-06-07

 ---
  lenses/nagioscfg.aug | 2 +-

Second, we use "Fix Released" in the development release since the bug did once affect the development release but was fixed at some point since.