Ubuntu
apt-cacher-ng package

  1. Bug #1162876
  2. Comment #4

Comment 4 for bug 1162876

Revision history for this message
Steve Langasek (vorlon) wrote :

Chris, I'm accepting this into precise-proposed because from Colin I understand re-validating a prospective patch is quite time-consuming with a long customer round-trip. But the patch here is suboptimal; in future SRUs, please avoid code changes unrelated to the bugs you're trying to fix.

In this case, there are:

 - renamed members in a class (m_nReqRangeFrom, m_nReqRangeTo)
 - an API change that affects parsing behavior when an option appears more than once in the config, which is unrelated to the bugs here (SetOption)
 - renamed defines (EFLAG_DISCON, EFLAG_DO_DISCON)
 - logging changes

All of these are unrelated to the bugfixes, and make code review of the diff more time-consuming and error-prone. I've satisfied myself that they're reasonably safe here, but such changes should not be included in an SRU - an SRU should include the minimal change necessary to fix the bug.