The current delta is:
* d/p/0001-ucm2-Qualcomm-sc8280xp-fix-device-numbers.patch
* d/p/0001-acp63-add-initial-support-for-AMD-Pink-Sardine-ACP63.patch
* d/p/0002-acp63.conf-use-symbolic-link.patch
* d/p/0003-acp62-add-initial-support-for-AMD-ACP-v6.2-RPL.patch
=> Those are in 1.2.10 and can be dropped on a merge
* d/p/0001-Add-initial-support-for-MediaTek-mt8390-evk-and-mt83.patch
=> This is not upstream AFAICS
=> It does not have the dep-3 patch headers for Forwarded or Origin and
sadly such moments trying to find what happened is just why they should
always be added.
This is a sin of the past and not your fault Artur, but your patch also
misses those, so let me teach you about that ...
I'll do that for you here for noble to make some progress, but you can still
fix this up for the SRU uploads.
It really would have helped if you'd have been available after you pinged
me on IRC. At the end of the day we want to teach, not just correct uploads.
Analyze for merge readiness:
The current delta is: ucm2-Qualcomm- sc8280xp- fix-device- numbers. patch acp63-add- initial- support- for-AMD- Pink-Sardine- ACP63.patch acp63.conf- use-symbolic- link.patch acp62-add- initial- support- for-AMD- ACP-v6. 2-RPL.patch
* d/p/0001-
* d/p/0001-
* d/p/0002-
* d/p/0003-
=> Those are in 1.2.10 and can be dropped on a merge
* d/p/0001- Add-initial- support- for-MediaTek- mt8390- evk-and- mt83.patch
=> This is not upstream AFAICS
=> It does not have the dep-3 patch headers for Forwarded or Origin and
sadly such moments trying to find what happened is just why they should
always be added.
This is a sin of the past and not your fault Artur, but your patch also
misses those, so let me teach you about that ...
Learning links: /dep-team. pages.debian. net/deps/ dep3/ /github. com/canonical/ ubuntu- maintainers- handbook/ blob/a5a386be1b e1507fbd1dd8842 699b0758042169c /DebianPatch. md#the- patchfile- header
- Standard for patch headers: https:/
- If you want it a bit more consumable https:/
Also your git export is not of the hash that is in the final repository
Instead it is from the PR which might go away and is therefore harder to find.
And finally, no trace back from the patch to the bug that made it being added.
So overall your patch should ideally be like:
- use correct git hash
- add Origin
- add Applied-Upstream
- Add last-update
Which makes it start like:
From b422a8e08cb3845 053ece1fc832294 adca21a684 Mon Sep 17 00:00:00 2001
From: Shuming Fan <email address hidden>
Date: Thu, 12 Oct 2023 10:07:36 +0800
Subject: [PATCH] ucm2: soundwire: add rt713 SDCA device
Closes: https:/ /github. com/alsa- project/ alsa-ucm- conf/pull/ 363
Signed-off-by: Shuming Fan <email address hidden>
Signed-off-by: Jaroslav Kysela <email address hidden>
Origin: upstream, https:/ /github. com/alsa- project/ alsa-ucm- conf/commit/ b422a8e08cb3845 053ece1fc832294 adca21a684 /bugs.launchpad .net/ubuntu/ +source/ alsa-ucm- conf/+bug/ 2042902
Bug: https:/
Applied-Upstream: v1.2.11
Last-Update: 2023-11-24
---
...
I'll do that for you here for noble to make some progress, but you can still
fix this up for the SRU uploads.
It really would have helped if you'd have been available after you pinged
me on IRC. At the end of the day we want to teach, not just correct uploads.