Comment 11 for bug 1024057

Revision history for this message
Margarita Manterola (marga-9) wrote :

The source code is in the .vala files. The .c files are generated from there and almost unreadable. So, when making changes, they should be made in the .vala files and then the affected c files need to be regenerated. To fix this bug I had to patch a .vala file, so the corresponding .c file gets regenerated as well.

The current Makefile.in generates a Makefile that requires the file "config.vapi" to be present, or it fails. This file is not shipped in the .tar.gz, by mistake. I already filed https://bugs.launchpad.net/activity-log-manager/+bug/1083160 about this.

In the quantal version, the solution was to add the config.vapi file. I didn't know this, and I thought it was less invasive to remove this requirement which didn't seem to make any differences in the output (regenerating the original c files produced no changes).

I can fix it the quantal way, by adding the config.vapi file, or fix it in my original way by removing the line from the Makefile. The end result is the same, so I don't care, whatever makes it easier for this to go into precise.

Also, about the userdirs file, there are many reasons why it might be that it's not there, or just partially there:
1) First session was via ssh instead of logging in
2) Removed by the user to avoid seeing a bunch of not wanted directories on the left of the file-window
3) Regenerated by the user by running xdg-user-dirs-update after removing some of the default directories

So, this is no bug on the file not being there. The bug is assuming that it will be. The glib call is documented to return NULL when the user didn't set this directory. Software should take this into account.