commit c740b542147f7e53cac12c46860bf8228d6ae5f6
Author: Harald Jensås <email address hidden>
Date: Mon Jan 7 22:38:02 2019 +0100
Remove default role-name from merge network param script
The merge-new-params-nic-config-script.py previosly had the
'Controller' role as the default for --role-name. It is not
obvious that this parameter must be changed when merging
nic config templates.
Remove the default and make the argument required. Improves
UX since user error is less likely.
Making the mistake of using a Role with too many networks
is'nt as forgiving since we now only pass parameters for
the role.networks.
Reviewed: https:/ /review. openstack. org/629051 /git.openstack. org/cgit/ openstack/ tripleo- heat-templates/ commit/ ?id=c740b542147 f7e53cac12c4686 0bf8228d6ae5f6
Committed: https:/
Submitter: Zuul
Branch: master
commit c740b542147f7e5 3cac12c46860bf8 228d6ae5f6
Author: Harald Jensås <email address hidden>
Date: Mon Jan 7 22:38:02 2019 +0100
Remove default role-name from merge network param script
The merge-new- params- nic-config- script. py previosly had the
'Controller' role as the default for --role-name. It is not
obvious that this parameter must be changed when merging
nic config templates.
Remove the default and make the argument required. Improves
UX since user error is less likely.
Making the mistake of using a Role with too many networks
is'nt as forgiving since we now only pass parameters for
the role.networks.
Related-Bug: #1800811 9a30ac10a7814a3 c01d50caf58
Change-Id: Iff9e364db66ad0