Author: Brian Conry
Author Date: 2022-07-05 14:24:06 UTC

Tweak spacing on ticket create/update with gnupg_widget

On the Ticket Create page the Subject is the last item in the "Create a
new ticket in ..." group before the option to include an article (if
present), but when $gnupg_widget is set there is a pair of checkboxes
displayed after the Subject.

The additional spacing after the Subject inputs, due to the "form-group"
class on the containing <div>, makes the checkboxes look like they're
closely related to the "Include Article" input when it is present, but
they are not.

A similar issue existed on the Ticket Update page, but in this case the
UI was inconsistent in that the encryption checkboxes were located above
the Subject textbox. They have been moved to be below the Subject in
addition to fixing the spacing inconsistency.

This change detects when $gnupg_widget is set and adjusts the location
of the "form-group" class appropriately to make the spacing align better
with the logical grouping of the controls.

Author: Brian Conry
Author Date: 2022-06-23 14:59:17 UTC

Make the Timezone config option a Select widget

This change converts the Timezone option to a Select widget, from a text
box, on the System Configuration page. This restricts the admin to
choosing from known-valid options.

This is the same list that is built and presented in the User
Preferences.

Note that while this list does not usually include deprecated timezone
names, the current value of the configuration option and the file-only
value of the option (if different from the current value) are both
added at the top of the list, even when they are deprecated.

Author: sunnavy
Author Date: 2022-06-03 18:41:46 UTC

Support to delete dangling attributes

In eb06b9aba1, we chose to bypass dangling "ContentHistory" attributes
and related transactions. Old versions still report these records and
allow user to delete transactions(but not attributes). If user uses an
old version and chooses to delete these transactions, which rt-validator
requires to find out dangling-but-allowed attributes, it will continue
reporting these attributes(even with eb06b9aba1):

    Record #31 in Attributes references a nonexistent record in Attributes
      ObjectId => '30' => id

This commit allows user to delete these attributes to clean things up.

Author: Brian Conry
Author Date: 2022-05-25 13:51:59 UTC

Allow CKEDITOR (rich text) boxes to vary in height

Set the height of CKEDITOR based on context.

For ones with the "messagebox" class continue to use
MessageBoxRichTextHeight.

For others use the "rows" attribute of the original textarea to
calculate a height that is approximately equivalent in editable area.

Author: Brad Embree
Author Date: 2022-04-29 21:02:27 UTC

Add an AfterWipeout callback to Shredder

Used by RT::Site::Symas for returning back to the Ticket display page after clicking a link to shred an attachment.

See ticket 246765.

Author: Jason Crome
Author Date: 2022-04-06 18:36:45 UTC

Define subscription rows in component init

The row options were originally hard-coded. By moving this to init, then
iterating over the list of values will allow extensions to modify the
settings in the MassageSubscriptionFields callback, where it wasn't
possible before.

Author: Jason Crome
Author Date: 2022-03-14 14:01:31 UTC

Correct location of New Dashboard menu item

This was moved in RT5, but the documentation didn't reflect the move.
Docs now match reality.

Author: Jason Crome
Author Date: 2022-03-14 13:51:08 UTC

Clarify handling of bounced mails wrt SetOutgoingMailFrom

While it is true that with this setting enabled bounced emails will get
treated as incoming mails (and thusly have a ticket created), the docs
failed to mention that RT also catches most bounced emails and therefore
doesn't create a ticket. Clarified this wording so usage of this setting
seems less concerning.

Author: sunnavy
Author Date: 2022-02-23 21:13:27 UTC

Make ckeditor toolbar collapsable and remember its state

Author: sunnavy
Author Date: 2022-02-18 21:46:01 UTC

Make all ckeditor toolbar groups the same height

".cke_combo_button"("Formatting Styles" and "Paragraph Format" use it)
has "margin-bottom: 5px" by default, which is 2px bigger than the other
toolbar groups.

By making them the same height, toolbar's second row will be able to
start from the leftmost instead of weirdly below the "Text Colors"
group.

Author: Jim Brandt
Author Date: 2022-02-01 18:42:20 UTC

Skip ContentHistory entries when validating Attributes

ContentHistory entries were added to the Attributes table as
a way to track deleted Saved Searches, Dashboards, and
Subscriptions. Since the attribute they were created to track
was deleted, it is correct for that original attribute to no
longer exist. Exclude these records from the referential
integrity check on Attributes.

Author: Jason Crome
Author Date: 2022-01-13 19:33:45 UTC

Run a variable number of scrip tests.

Adding a scrip that was disabled by default caused the number of tests
to climb, which caused an error in the test suite because we ran more
tests than expected. By making this number variable, we avoid having the
same issue down the road.

Author: sunnavy
Author Date: 2022-01-03 22:09:28 UTC

Upgrade Dropzone to 5.9.3

Author: sunnavy
Author Date: 2021-12-27 19:26:17 UTC

Test "Clear Mason Cache" functionality

Author: sunnavy
Author Date: 2021-12-03 21:35:42 UTC

Add SLAViolation event support

As the event is saved in transactions, it shows up in ticket history and
transaction searches automatically. The following new transaction
columns are added for convenience:

    SLAViolationDuration
    SLAViolationDurationAsString
    SLAViolationBusinessDuration
    SLAViolationBusinessDurationAsString

Author: sunnavy
Author Date: 2021-12-01 20:05:53 UTC

Add tests for shared joins in watcher bundle optimization

Author: Brett Smith
Author Date: 2021-11-30 15:22:48 UTC

Document that database credentials are optional

Author: Brett Smith
Author Date: 2021-11-19 16:47:29 UTC

Document version requirement in README.PostgreSQL

Our primary README specifies a version requirement. However, this number
is primarily based on what version PostgreSQL supported at the time of
release. The other database READMEs provide a technical justification
for their version requirements. Follow that same pattern for PostgreSQL.

Saying that we require PostgreSQL 9.1 "starting with RT 5.0.0" is
probably an oversimplification. The reality probably depends on the
versions of every piece of the stack, including libpq, DBD::Pg, and RT
itself. But RT 5.0.0 is the first release where we documented PostgreSQL
9.1+ as the version requirement (see 0e0e496580cd), so go with that.

Author: Steven Burr
Author Date: 2021-06-11 18:56:06 UTC

Add popup help capabilities

Help icons can be added anywhere on RT pages. When clicked, they
will display the contents of an associated Article in a dismissable
popover dialog. The Article content can be retrieved server-side
at page rendering time or dynamically when clicked via AJAX.

The (user-overridable) $ShowInlineHelp setting governs whether the
help icons for inline popup help topics are displayed or not.

No help articles are actually added as part of this commit.
Just the underlying functionality.

Author: craig kaiser
Author Date: 2021-09-08 14:04:02 UTC

Add tests for Configurations export/import

Author: sunnavy
Author Date: 2021-09-03 13:38:24 UTC

Respect MessageBoxIncludeSignature config on ticket update pages

Author: Steven Burr
Author Date: 2021-09-01 13:06:46 UTC

Retain signature if quoting content on correspondence

The UpdateContent argument to Ticket/Update.html will be quoted
as the initial value of the correspondence. It is passed, for example,
when quoteselection.js has created the ticket update link after
processing the current selection. However, the current behavior will
always hide any signature if this argument is supplied. This commit
changes the signature behavior to be the same as when UpdateContent
is not supplied.

Author: craig kaiser
Author Date: 2021-07-26 18:44:17 UTC

Ensure unique ID values for external custom field values inputs

RT::CustomFieldValue objects generated from external values all have an
ID value of 1. Bootstrap requires checkboxes and radio inputs to have
unique "id" attributes in order to work.

Author: Steven Burr
Author Date: 2021-07-26 15:50:50 UTC

Add template examples to documentation

Author: sunnavy
Author Date: 2021-07-20 22:24:20 UTC

Use JSON format for complicated configuration contents when possible

Format "perl" will still be used for cases where JSON doesn't support
like regex.

The main reason to prefer JSON here is to handle unicode more robustly.
E.g. perl treats the following strings differently in a subtle way:

    # Internal UTF-8 flag is off.
    $a = "\x{c7}"; # Ç

    # Internal UTF-8 flag is on.
    use utf8;
    $a = 'Ç';

    # Internal UTF-8 flag is on.
    use Encode;
    $a = decode('UTF-8', encode('UTF-8', "\x{c7}"));

Thus contents containing unicode data could confuse perl sometimes and
cause RT to decode data incorrectly.

Author: craig kaiser
Author Date: 2021-07-16 15:33:36 UTC

Do not run ValidateLifecycle on disabled lifecycles

A lifecycle should not be validated if it is disabled as lifecycles at
the moment cannnot be deleted, only disabled.

Author: Steven Burr
Author Date: 2021-06-03 13:06:29 UTC

more WIP

Author: sunnavy
Author Date: 2021-06-02 14:39:58 UTC

Test branches-ignore of github actions

Author: Steven Burr
Author Date: 2021-06-01 17:39:55 UTC

WIP

Author: sunnavy
Author Date: 2021-05-24 18:54:00 UTC

Remove "ModifyAsset" requirement for asset custom role member changes

This is to be consistent with ticket custom roles and custom fields.
Asset core roles like "Owner", "HeldBy" and "Contact" are still guarded
by "ModifyAsset".

Author: Steven Burr
Author Date: 2021-05-20 15:47:59 UTC

Add tests for per-class article uniqueness

Author: sunnavy
Author Date: 2021-03-23 19:54:13 UTC

Test Transaction Created/Creator in TicketSQL

Author: sunnavy
Author Date: 2021-03-12 22:30:25 UTC

Update tests for the deletion of article PreCreate page

Author: Jim Brandt
Author Date: 2021-02-15 17:11:33 UTC

Refine case-insensitive test for Select CF to use HasEntry

The Validation update in 40f8cd4d5f no longer allows values
to be added to a Select CF if the case is inconsistent.
Refine the existing test to show the new validation and
also show that HasEntry retains the previous
case-insensitive check for backward compatibility.

Author: Jim Brandt
Author Date: 2021-02-11 16:30:57 UTC

Avoid expensive COUNT query on group dashboard rights

The call to ->Count on the groups collection to check if the
user has the right CreateGroupDashboard generates the query:

    SELECT COUNT(DISTINCT main.id) FROM Groups main
        CROSS JOIN ACL ACL_2 JOIN CachedGroupMembers...

This is triggered when dashboard rights are granted at the
group level and users do not have CreateOwnDashboard. It
is called when building the menu, so on every page load.

Since we are only checking to see if the user has the right
via at least one group, just check for one value in the
results rather than running the COUNT. This should
generate a less expensive query.

Author: Blaine Motsinger
Author Date: 2021-01-27 00:21:49 UTC

Add --clear-user option to rt-clean-sessions

This option will delete all user sessions for a given user.

Author: Dianne Skoll
Author Date: 2021-01-21 15:48:17 UTC

If we unmerge tickets merged on old RT, provide informative message

We mention that some information may have been lost, and we also avoid
RT from logging as follows:

[error]: Unable to load merge data for 1 (/opt/rt5/local/plugins/RT-Extension-UnmergeTickets/lib/RT/Ticket_Overlay.pm:370)
[warning]: Rollback and commit are mixed while escaping nested transaction at ...DBIx/SearchBuilder/Handle.pm line 892, <GEN45> line 64.

Author: Dianne Skoll
Author Date: 2021-01-20 14:09:26 UTC

Add test for cleaning up MS Outlook HTML mail.

Author: sunnavy
Author Date: 2018-02-08 13:46:29 UTC

Add rt-rebuild-sort-order command to rebuild SortOrder

Author: Steven Burr
Author Date: 2021-01-15 16:04:24 UTC

Ensure values are valid for Select custom fields

The values to which Custom Fields of type 'Select' can be set should
be constrained to the list of defined values. While the Web interface
provided for this, the REST2 interface did not.

The ValidateValue method is implemented on the CustomField object
to ensure that values are valid for Select custom fields regardless
of how they are set.

Author: Blaine Motsinger
Author Date: 2020-12-31 00:27:45 UTC

Fix titlebox-title overlap on dark theme mobile

For smaller mobile browsers sizes like 375px wide, on dark theme,
the titlebox-title background color was overlapping text on the
lines above. This commit sets background color to transparent for
titlebox-title left so the background color on a wrapped line
doesn't cut off the text above it.

Author: Dianne Skoll
Author Date: 2020-12-29 16:38:44 UTC

Remove modal class selection for creating articles.

Instead, the article Class is chosen similarly to how Queue is chosen
for Tickets or Catalog is chosen for Assets: There is a pulldown
selection element in the create/edit page. Updating this refreshes
the page so the appropriate custom fields are presented for editing.

Author: Steven Burr
Author Date: 2020-12-16 15:15:50 UTC

Allow rt-passwd to enable/disable users and autogen passwords

Author: Dianne Skoll
Author Date: 2020-12-10 21:13:46 UTC

Make args to Helpers/QuickCreatePossibleOwners optional to avoid test failure in t/web/helpers-http-cache-headers.t

If we do not do this, then we get a warning which fails the test.

Author: craig kaiser
Author Date: 2020-12-01 18:03:57 UTC

 Add Recent Correspondence portlet to User Summary.html page

Author: Dianne Skoll
Author Date: 2020-11-24 15:33:49 UTC

Document RT_Config/SelfServiceArticleClass

Author: Dianne Skoll
Author Date: 2020-09-22 20:23:58 UTC

Issue the "Too late to safely run transaction-batch scrips!" warning at most once.

If it's issued dozens/hundreds/thousands of times, it could hide the real
error if invoked from a command-line script whose output is not captured.

(Note, however, that if DevelMode is configured, we do not suppress
repeated warnings.)

Author: Dianne Skoll
Author Date: 2020-09-25 14:32:35 UTC

Document setting up SSL connections between RT and PostgreSQL, MySQL and MariaDB

Author: Aaron Trevena
Author Date: 2020-09-25 09:46:19 UTC

Add nginx reverse proxy to web deployment documentation

Author: Aaron Trevena
Author Date: 2020-09-01 15:20:41 UTC

Update tests for mysql 8

Tests fail due to new Groups reserved word and other changes in mysql 8, requiring
Groups table to be escaped, add debug output for any failing validator results.

Author: Dianne Skoll
Author Date: 2020-08-07 16:16:22 UTC

Test Travis-CI speed with /var/lib/mysql in a tmpfs file system.

Author: Dianne Skoll
Author Date: 2020-08-07 15:43:03 UTC

Run tests against experimental docker image that runs MariaDB under eatmydata.

Author: Aaron Trevena
Author Date: 2020-08-06 19:07:42 UTC

Update Configuration display to scrub sensitive fields

Author: Dianne Skoll
Author Date: 2020-08-05 12:56:27 UTC

Document (dangerous) DB optimizations to improve test speed.

Author: Dianne Skoll
Author Date: 2020-08-05 12:56:27 UTC

Document (dangerous) DB optimizations to improve test speed.

Author: Dianne Skoll
Author Date: 2020-07-29 18:39:21 UTC

Make RT_TEST_PARALLEL default to the number of cores on the test machine.

We use the command "nproc" to get the number of cores. If this command
fails (it might not exist on non-Linux systems) we revert to the old
default of 5.

Author: Dianne Skoll
Author Date: 2020-07-20 16:03:33 UTC

Fix pathnames; fix a few minor misspellings/typos.

Author: Aaron Trevena
Author Date: 2020-07-16 20:02:06 UTC

Catch errors decoding wide-characters in HTTP Headers

Detect wide-characters in HTTP Header and attachment filenames, and
avoid decoding them and causing a fatal wide-character error.

This edge case occurs in REST1 API, due to the way some client libraries,
particularly Perl's HTTP::Request family handle utf8 in multi-part fields.

Author: sunnavy
Author Date: 2020-07-13 19:49:40 UTC

Store the attribute Name in the ContentHistory's Description field

With this, we can easily identify the type of shared settings like
SavedSearch, Dashboard, etc.

Author: sunnavy
Author Date: 2020-06-11 22:03:21 UTC

Add basic tests for %PriorityToSLA config

Author: sunnavy
Author Date: 2020-05-21 14:34:08 UTC

No need to explicitly quit gpg-agent launched in tests any more

Previously we needed this because we had gpg homedir set to a non-temp
path like "t/data/gnupg/keyrings/" in some tests. Since 4126e51357, all
gpg homedirs in tests are temporary, and with 513fe24d35, these temp
dirs will be deleted after tests. When homedirs are deleted, gpg-agent
will quit automatically.

Author: Craig
Author Date: 2020-05-06 21:07:58 UTC

Add tests for lifecycle-ui caching when config is updated

Author: Craig Kaiser
Author Date: 2020-04-23 20:36:14 UTC

Decode mailgate args

Need to decode mailgate args before they reach the database or else Postgres
can run into encoding issues.

Using a queue name in the mailgate command that has ascii characters
can result in RT not being able to find and load the queue if the queue
name string is not decoded.

Author: sunnavy
Author Date: 2019-10-21 21:25:31 UTC

Automatically render 2 columns for common ticket widgets on large screen

For text/wikitext type of cfs, as they are supposed to contain quite a
few content, we intentionally let them take up the whole row.

People can add "two-col-left" or "two-col-right" css class to control
the position of fields, and "two-col-full" is to take up the whole row.

Author: Craig Kaiser
Author Date: 2020-03-25 11:58:05 UTC

Create user-level docs for custom fields categories feature

Author: michel
Author Date: 2020-02-05 08:47:58 UTC

Use bootstrap for custom date ranges edit form.

Author: Craig Kaiser
Author Date: 2020-01-29 17:16:14 UTC

Add test for calling MembersObj on unloaded group object

Author: Aaron Trevena
Author Date: 2020-01-14 17:59:53 UTC

Added helpers to scrub sensitive values for logging and transactions

Author: sunnavy
Author Date: 2020-01-09 21:55:41 UTC

Don't load disabled SharedSetting records like Dashboards

This is to retain previous behavior. Disabled attributes on the other
hand, could still be loaded so we can investigate data easily.

Author: Blaine Motsinger
Author Date: 2019-11-23 00:45:19 UTC

Add test for self service group tickets

Author: sunnavy
Author Date: 2019-10-24 12:32:06 UTC

Test only queue-related ocfs will be shredded on queue shredding

We don't want to shred ocfs of classes and catalogs with the same id.

Author: Craig Kaiser
Author Date: 2019-09-27 16:10:39 UTC

Center lifecycle editor

Author: sunnavy
Author Date: 2019-08-29 19:19:29 UTC

Add additional_attrs support for external auth

Previously subroutine references in attr_map had 2 modes, to get attr
names and values, respectively, which is a bit confusing.

This commit adds additional_attrs config, where people can put attr
names used in subroutine references into. In this way subroutine
references is only used to get values, which is clearer.

Author: sunnavy
Author Date: 2019-07-23 20:38:52 UTC

Use hours when possible for negative ticket time durations strings

Previously negative ticket time durations were always shown as minutes,
which is inconvenient.

Author: sunnavy
Author Date: 2019-07-17 14:46:13 UTC

Add transaction query builder tests

Author: Jim Brandt
Author Date: 2019-06-26 18:58:50 UTC

Update tests with new parse failure log message

Author: sunnavy
Author Date: 2019-06-20 20:08:11 UTC

Add line chart type support

Author: sunnavy
Author Date: 2019-06-07 21:17:15 UTC

Update the old article menu "Tools -> Articles -> New Article" to "Articles -> Create" in doc

Author: Craig Kaiser
Author Date: 2019-05-24 19:45:38 UTC

Allow saved searches to be sorted

Saved searches are saved in the database as attributes meaning that the
order by cols method usually available is not.

Author: sunnavy
Author Date: 2019-05-17 17:33:44 UTC

Add config option $DisableRecentlyViewedTickets

RT lists current user's recently viewed tickets in menu by default.
Since it happens on most pages, it could slow down RT a bit. With this
config option, people can easily disable this feature.

Author: Blaine Motsinger
Author Date: 2019-03-19 23:35:48 UTC

Added new ISOTZ date formatter

This new formatter returns the object's date in ISO format with
TZ name abbreviation.

Author: sunnavy
Author Date: 2019-03-18 14:53:16 UTC

Make EditCustomFieldsSingleColumn a user preference

Author: Craig Kaiser
Author Date: 2019-03-04 20:42:21 UTC

Add whitelist for ForceShowHistory and ShowHeaders

Author: Jim Brandt
Author Date: 2019-02-27 15:13:37 UTC

Accept a ShowHistory arg as an override for the default setting

This allows a different loading mode for the history for
an single ticket display. This is useful for debugging when
the source HTML is needed for transactions and the default
scroll mode shows only "Loading...". It is also useful for
the TicketToPDF extension which needs to load the entire history
to generate a PDF.

Author: Craig Kaiser
Author Date: 2019-02-04 21:18:15 UTC

Do not return true if object is applied and disabled

The 'IsAdded' method should not return true by default
even if added to the context object if the applied object is disabled.

Author: Craig Kaiser
Author Date: 2019-01-25 16:10:06 UTC

Pass Object key to 'ProcessObjectCustomFieldUpdates' not TicketObj

If the Object key is not passed then the 'DryRun' arg is lost and a
commit will be run instead of a dry run.

Author: sunnavy
Author Date: 2019-01-22 20:25:03 UTC

Test Oracle session as the hanging issue is gone

Author: Craig Kaiser
Author Date: 2019-01-02 20:52:48 UTC

Create tests for row colors by condition

Author: Craig Kaiser
Author Date: 2018-12-14 20:22:58 UTC

Add POD documentation to RT tool

Author: Maureen E. Mirville
Author Date: 2018-12-06 21:28:49 UTC

Update Articles docs to include disabling ticket linking

Author: Maureen E. Mirville
Author Date: 2018-11-30 20:45:33 UTC

Add a footer to all initialdata templates and update styling

Author: Maureen E. Mirville
Author Date: 2018-12-07 21:35:48 UTC

Update query builder docs to include sort order indicator

Author: sunnavy
Author Date: 2018-12-06 21:21:31 UTC

Add empty value option first when rebuilding select options to make IE happy

Otherwise, IE(at least 11) wrongly selects the first non-empty option.
e.g. on search chart page, there will be 3 repetitive Group By "Status"
and 3 repetitive Calculate "Ticket count" :/

Author: Craig Kaiser
Author Date: 2018-11-29 16:03:35 UTC

Make the Y axis for charts Min and Max value configurable from web UI

Author: Gergely Nagy
Author Date: 2018-11-06 12:46:03 UTC

Code cleanup in RescueOutlook

Instead of using three separate substitution steps, use just one with three big
groups and /x for readable code.

Author: Craig Kaiser
Author Date: 2018-10-29 20:24:06 UTC

Load Content rather than Attribute object for RecentlyViewedTickets

Previously, if the RecentlyViewedTickets content somehow was set
to undef, $content still evaluated to true because it was an
RT::Attribute object. Calling the Content method then resulted in:

    Can't use an undefined value as an ARRAY reference

This caused a 500 error for the end-user.

Loading the content provides the intended true/false value and handles
the empty content case.

Author: Maureen E. Mirville
Author Date: 2018-03-08 20:34:29 UTC

Further improve modify rights UI for unselected principal

Previous commit (#01758542d) hid all rights options from UI when
a valid principal user or group was not selected. Rather than
hiding the list of rights, the list is now disabled and faded
for a less aggressive visual cue.

Fixes: I#29892

Author: sunnavy
Author Date: 2018-10-03 20:42:19 UTC

Test broken html that wraps gpg encrypted message

Author: sunnavy
Author Date: 2018-10-04 17:01:42 UTC

Test exchange mangled MIME structure

Author: sunnavy
Author Date: 2018-08-30 16:03:08 UTC

Fix the uninitialized warning in vsplit when the passed value is undef