I tend to agree with you on server side, but the bug still persists. Lets say atleast on addons.
I see the video of 6.1 by Jignesh, I wonder about line 360 of res_partner.py (0:25). You feel its working due to this line does the trick, it compares name first and then the others.
"ids = self.search(cr, user, [('name', '=', name)], args, limit=limit, context=context)" -- I do not have this line.
I do not see this line and that is what making me do more analysis.
The reason being the condition on "len(ids) < limit", when name_search gets limit=None and hence any search on contacts of partner results in ONLY the search of zip. All the other criterias are getting ignored.
I would say rev 4021 causes regression.
Scenario : Go to partners:search something on contacts field, results are not the right ones.
I would like to request you to recheck.
Thanks for taking time for the review, appreciated.
Olivier,
I tend to agree with you on server side, but the bug still persists. Lets say atleast on addons.
I see the video of 6.1 by Jignesh, I wonder about line 360 of res_partner.py (0:25). You feel its working due to this line does the trick, it compares name first and then the others.
"ids = self.search(cr, user, [('name', '=', name)], args, limit=limit, context=context)" -- I do not have this line.
Look at http:// bazaar. launchpad. net/~openerp/ openobject- server/ 6.1/view/ head:/openerp/ addons/ base/res/ res_partner. py#L347, I have this code.
I do not see this line and that is what making me do more analysis.
The reason being the condition on "len(ids) < limit", when name_search gets limit=None and hence any search on contacts of partner results in ONLY the search of zip. All the other criterias are getting ignored.
I would say rev 4021 causes regression.
Scenario : Go to partners:search something on contacts field, results are not the right ones.
I would like to request you to recheck.
Thanks for taking time for the review, appreciated.
Apologies for any confusions.
Regards,
Serpent Consulting Services.