Comment 19 for bug 795765

Revision history for this message
Matthieu Baerts (matttbe) wrote :

Hello,

About this fix for the SRU, it seems it's not correct (as said Jeremy on comment #15) according to Jonathan Matthew, rhythmbox developer:
 "Thanks for the patch, but this isn't quite the right fix. The playlist parser
  thread isn't supposed to refer to the main thread's cancellable, because the
  user might have started playing something else by the time it runs. Instead,
  the shell player should have been clearing its pointer to the cancellable when
  pausing playback. I've made this change in commit 98e5a25."

The new patch is available there:
 * Git: http://git.gnome.org/browse/rhythmbox/commit/?id=98e5a25b3c32c9915357968a78783c1ac21c7130
 * Quantal: lp:~ubuntu-desktop/rhythmbox/ubuntu => https://bazaar.launchpad.net/~ubuntu-desktop/rhythmbox/ubuntu/revision/189
 * Raring: https://bazaar.launchpad.net/~ubuntu-branches/ubuntu/raring/rhythmbox/raring-proposed/revision/220#debian/patches/11_fix_cd_pausing.patch )

This is why I guess it's better to add this tag: verification-failed