Comment 3 for bug 997763

Revision history for this message
Vish Ishaya (vishvananda) wrote :

this actually looks acceptable with the refactor into a separate function and a test. I think we can handle the performance penalty of making an actual request for nw_info.

It would also be nice to handle:

nova floating-ip-list

to allow it to not error like it does above if the instance has been deleted.

 and to allow:

nova remove-floating-ip <instance> <floating_ip>

to work even if the instance is gone. (my initial reading of the code makes it seem like this will work but I'm not totally sure)