The CreateAndConnectCfgDrive and DeleteVOpt tasks were passing the
instance into the task.Task init as the first argument. The first arg
for the Task init is actually the task name [1]. This means that those
task names were string representations of the instance which will cause
failures if there are any non-ascii characters. This corrects the Task
init calls by removing instance as the first argument. The name kwarg
is now being used throughout the PowerVM tasks to avoid similar issues
in the future.
Reviewed: https:/ /review. openstack. org/543571 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=db686fe1856 456e5e1486f0935 aa4426c805520f
Committed: https:/
Submitter: Zuul
Branch: master
commit db686fe1856456e 5e1486f0935aa44 26c805520f
Author: esberglu <email address hidden>
Date: Mon Feb 12 12:18:57 2018 -0600
Use correct arguments in task inits
The CreateAndConnec tCfgDrive and DeleteVOpt tasks were passing the
instance into the task.Task init as the first argument. The first arg
for the Task init is actually the task name [1]. This means that those
task names were string representations of the instance which will cause
failures if there are any non-ascii characters. This corrects the Task
init calls by removing instance as the first argument. The name kwarg
is now being used throughout the PowerVM tasks to avoid similar issues
in the future.
[1] https:/ /github. com/openstack/ taskflow/ blob/3. 1.0/taskflow/ task.py# L62
Change-Id: I991a5ea33daa9a 21f774fe24882ed 40f990b8e0e
Closes-Bug: #1748950