Comment 22 for bug 1221190

Revision history for this message
Stanislaw Pitucha (stanislaw-pitucha) wrote : Re: Image format not enforced when using rescue

I really like the file renaming, but even if we changed all of the places in openstack itself, there's bound to be a number of custom modules or supporting scripts people use that assume this name. I know we have a number of those.

To further complicate the shutdown check, you can probably find some situations where proper shutdown doesn't happen. Host reboots (crashes or forced by dos) would not run shutdown. Live migration be another edge case to check, I guess.

Just to brainstorm more ideas: what about renaming the files and leaving a symlink in place? This will require lots of renaming in libvirt driver, but hopefully it will fix the problem itself. For anything that gets accidentally left over or things that exist outside of openstack's control, the symlink from disk -> disk.{format} should be enough to keep it working.
Or maybe even better -> create disk.{format} itself as a symlink to disk and verify the format based on that file?