Comment 2 for bug 1064083

Reviewed: https://review.openstack.org/14188
Committed: http://github.com/openstack/nova/commit/fb101685cc14ed9b0396ce966e571d3fb457c32f
Submitter: Jenkins
Branch: master

commit fb101685cc14ed9b0396ce966e571d3fb457c32f
Author: Chris Behrens <email address hidden>
Date: Mon Oct 8 23:33:17 2012 +0000

    XenAPI should only snapshot root disk

    Change ID I3e2973 broke XenAPI migrations (resizes) as it caused snapshots
    of all disks (including swap and ephemeral disks, if enabled) to be sent
    over to the destination host. The destination only expects vhds for the
    root disk, named by sequence numbers. swap and ephemeral disks ended up
    with sequence numbers, also, messing up the re-building of the chain on
    the destination.

    Fixes bug 1064083

    Change ID I3e2973 also didn't change the stub of VM.snapshot to
    VDI.snapshot, but tests still passed due to the new code ignoring all
    exceptions while snapshotting. Potential issues in
    snapshot_attached_here() would also be ignored due to excessive stubbing
    in the xenapi migration testing. This is also addressed here.

    Change-Id: I145030f92a75615d056a30cabcb6ca97e34a8b6c