Author: Marc Peña
Author Date: 2020-01-10 16:27:22 UTC

Merge remote-tracking branch 'parent/master' into create-snap-package

Author: Nextcloud bot
Author Date: 2020-01-10 03:27:02 UTC

[tx-robot] updated from transifex

Author: Akula
Author Date: 2018-09-18 21:52:56 UTC

Full update for filestreaming Windows

Author: Camila San
Author Date: 2018-09-11 14:11:47 UTC

Updates submodule qtmacgoodies.

Signed-off-by: Camila San <hello@camila.codes>

Author: Camila San
Author Date: 2018-08-27 19:58:39 UTC

Mounts fuse drive with auto_cache option.

Signed-off-by: Camila San <hello@camila.codes>

Author: Markus Goetz
Author Date: 2018-06-18 15:38:23 UTC

SettingsDialogMac: Show the page for the newly created account

Author: Olivier Goffart
Author Date: 2018-08-07 07:32:14 UTC

SyncEngine: Fix renames making hierarchy inversion

Issue #6694

Author: Olivier Goffart
Author Date: 2018-08-14 11:35:04 UTC

Conflict handling: add the OC-ConflictBasePath header

Issue #6702

Author: Christian Kamm
Author Date: 2018-08-14 11:02:45 UTC

Windows: Release handle/fd when file open fails #6699

Author: Christian Kamm
Author Date: 2018-08-15 10:16:46 UTC

RemotePermissions: Fix empty vs null

Fixes two bugs that appeared since the introduction of the struct:
- when reading permissions from the journal, null ("") was read as
  empty-not-null
- when reading permissinos from the server, empty ("") was read as null

Addresses #4608

Author: Christian Kamm
Author Date: 2018-08-15 09:06:51 UTC

nautilus: Fix GET_MENU_ITEMS with utf8 filenames #6643

Author: Olivier Goffart
Author Date: 2018-07-26 14:05:26 UTC

Data-Fingerprint: Fix backup detection when fingerprint is empty

Add a test to test the data fingerprint feature make me realize it was broken.
The code was relying in the distinction between empty and null QByteArray,
but this was a bad idea as this difference is lost when going through QString.

Author: Olivier Goffart
Author Date: 2018-08-07 15:43:35 UTC

OAuth: Fix infinite loop when the refresh token is expired

The server reply with a code 400 when the token is invalid,
the client was understanding this error as a network error, and was retying
again with the same token.

Instead, we must rely on what the json is saying, even if the reply is
not a 200 code.

Issue https://github.com/owncloud/enterprise/issues/2777

Author: Markus Goetz
Author Date: 2018-08-09 11:37:50 UTC

Windows: Don't ignore files with FILE_ATTRIBUTE_TEMPORARY

Too many applications incorrectly use this attribute.

For #6696 #6610

Author: Dominik Schmidt
Author Date: 2018-07-25 13:37:27 UTC

Support higher resolution theme icons

Author: Olivier Goffart
Author Date: 2018-08-07 07:50:55 UTC

MSI: Fix crash in the auto updater

'auto' here is a QStringBuilder referencing a temporary

Ammend commit 150d4f5935c9480cae0a84506af4efa940b64095
(MSI: Always with logfile #6609)

Found in the crash reporter:
https://sentry.io/owncloud/desktop-win-and-mac/issues/623245771/

Author: Markus Goetz
Author Date: 2018-07-24 13:41:26 UTC

Settings: Attempt to fix rename issue on old macOS

Found by @hurradieweltgehtunter

Author: Christian Kamm
Author Date: 2018-07-25 09:13:14 UTC

Do not require server replies to contain an mtime

The check was added for #6317 in commit
13eb64584f5f96647ced39dcd3252860ebec5a37.

We did see missing mtimes in replies in tests with live servers though.
Possibly those were old incomplete responses cached in the stat cache?

Author: Markus Goetz
Author Date: 2018-07-20 14:25:29 UTC

mirall.desktop.in: Remove buggy comments

Author: Markus Goetz
Author Date: 2018-07-19 15:11:47 UTC

sqlite: Update bundled version to 3.24.0

For OS X and Windows.

Author: Christian Kamm
Author Date: 2018-06-26 11:36:20 UTC

Update: Report on readdir() errors #6610

Author: Olivier Goffart
Author Date: 2018-07-16 10:46:03 UTC

FolderMan::checkPathValidityForNewFolder: make sure to work when folder points to deleted folders

Note that we also needed to adjust the server url to contains the user name
in the folder wizard. (As checkPathValidityForNewFolder expect the user name)

Issue #6654

Author: Olivier Goffart
Author Date: 2018-07-13 08:20:34 UTC

Wizard: show a message when the URL is invalid

Rather than let Qt show "Host not found"

Issue #6646

Author: Olivier Goffart
Author Date: 2018-07-16 07:53:33 UTC

Log: Remove inaccurate comment about --logdebug

The exact string is actually "sync.*.debug=true\ngui.*.debug=true".
And this is not strictly equivalent to setting the env var, as it
calls QLoggingCategory::setFilterRules.
Over all, that's an implementation details that users do not care about.

Author: Olivier Goffart
Author Date: 2018-07-04 13:03:16 UTC

Reconcile: When detecting a local move, keep the local mtime

https://github.com/owncloud/client/issues/6629#issuecomment-402450691

Author: Markus Goetz
Author Date: 2018-06-19 15:18:17 UTC

Introduce an about dialog

Every proper application has that!

For decreasing window height in #6075

Author: Olivier Goffart
Author Date: 2018-06-29 08:43:01 UTC

Upload: Store the size in the UploadInfo, and compare it when resolving potential conflict

This is about the conflicts that happens when the file has been uploaded
correctly to the server, but the etag was not recieved because the connection
was closed before we got the reply.

We used to compare only the mtime when comparing the uploaded file and the
existing file. However, to be perfectly correct, we also should check the
size.

This was found because TestChunkingNG::connectionDroppedBeforeEtagRecieved is
flaky. Example of faillure found in https://drone.owncloud.com/owncloud/client/481/5
while testing PR #6626

(very trimmed log:)

06-29 07:58:02:015 [ info sync.csync.csync ]: ## Starting local discovery ##
06-29 07:58:02:016 [ info sync.csync.updater ]: Database entry found, compare: 1530259082 <-> 1530259051, etag: <-> 1644a8c8750, inode: 1935629 <-> 1935629, size: 301 <-> 300, perms: 0 <-> ff, type: 0 <-> 0, checksum: <-> SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1, ignore: 0
06-29 07:58:02:016 [ info sync.csync.updater ]: file: A/a0, instruction: INSTRUCTION_EVAL <<=
06-29 07:58:02:972 [ warning sync.networkjob ]: QNetworkReply::NetworkError(OperationCanceledError) "Connection timed out" QVariant(Invalid)
.. next sync...
06-29 07:58:02:980 [ info sync.engine ]: #### Discovery start ####################################################
06-29 07:58:02:981 [ info sync.csync.csync ]: ## Starting local discovery ##
06-29 07:58:02:983 [ info sync.csync.updater ]: Database entry found, compare: 1530259082 <-> 1530259051, etag: <-> 1644a8c8750, inode: 1935629 <-> 1935629, size: 302 <-> 300, perms: 0 <-> ff, type: 0 <-> 0, checksum: <-> SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1, ignore: 0
06-29 07:58:02:983 [ info sync.csync.updater ]: file: A/a0, instruction: INSTRUCTION_EVAL <<=
06-29 07:58:02:985 [ info sync.csync.csync ]: ## Starting remote discovery ##
06-29 07:58:02:985 [ info sync.networkjob ]: OCC::LsColJob created for "http://localhost/owncloud" + "" "OCC::DiscoverySingleDirectoryJob"
06-29 07:58:02:987 [ info sync.csync.updater ]: Database entry found, compare: 1530259082 <-> 1530259051, etag: 1644a8c8b26 <-> 1644a8c8750, inode: 0 <-> 1935629, size: 301 <-> 300, perms: ff <-> ff, type: 0 <-> 0, checksum: SHA1:5adcdac9608ae0811247f07f4cf1ab0a2ef99154 <-> SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1, ignore: 0
06-29 07:58:02:987 [ info sync.csync.updater ]: file: A/a0, instruction: INSTRUCTION_EVAL <<=
06-29 07:58:02:989 [ info sync.csync.csync ]: Update detection for remote replica took 0.004 seconds walking 13 files
06-29 07:58:02:990 [ info sync.engine ]: #### Discovery end #################################################### 9 ms
06-29 07:58:02:990 [ info sync.database ]: Updating file record for path: "A/a0" inode: 1935629 modtime: 1530259082 type: 0 etag: "1644a8c8b26" fileId: "16383ea4" remotePerm: "WDNVCKR" fileSize: 301 checksum: "SHA1:cc9adedebe27a6259efb8d6ed09f4f2eff559ad1"
06-29 07:58:02:990 [ info sync.csync.reconciler ]: INSTRUCTION_UPDATE_METADATA client file: A/a0
06-29 07:58:02:990 [ info sync.csync.csync ]: Reconciliation for local replica took 0 seconds visiting 13 files.
06-29 07:58:02:990 [ info sync.csync.reconciler ]: INSTRUCTION_UPDATE_METADATA server dir: A
06-29 07:58:02:990 [ info sync.csync.csync ]: Reconciliation for remote replica took 0 seconds visiting 13 files.
06-29 07:58:02:990 [ info sync.engine ]: #### Reconcile end #################################################### 9 ms
06-29 07:58:02:990 [ info sync.database ]: Updating local metadata for: "A/a0" 1530259082 302 1935629
FAIL! : TestChunkingNG::connectionDroppedBeforeEtagRecieved(small file) '!fakeFolder.syncOnce()' returned FALSE. ()

Author: Olivier Goffart
Author Date: 2018-06-29 08:06:57 UTC

TestOAuth: Don't have global static QObject

Fix a strange warning seen on the log from the CI on Windows in
https://github.com/owncloud/client/pull/6621

The test shows, at the beginning
QObject::connect: No such signal DesktopServiceHook::destroyed(QObject*)
And crashes at the and.

My guess is that when QDesktopServices::setUrlHandler is called, the
QMetaObject is not yet initialized

But this is probably not the reason of the crash

Author: Olivier Goffart
Author Date: 2018-06-26 18:32:08 UTC

OAuth: Remove the timeout

There is no real reason to have a timeout. The connection can stay open
as long as we are not authenticated. The User can still re-open a browser
from the UI at any time.

Issue #6612

Author: Markus Goetz
Author Date: 2018-06-21 11:55:42 UTC

UpdateInfo: Remove unused code

Author: Olivier Goffart
Author Date: 2018-06-18 10:43:21 UTC

Wizard + OAuth: Make opening a new browser after clicking back works again

Issue #6574

When there is an error in the advanced page, OwncloudAdvancedSetupPage::updateStatus
(and others) call completeChanged(), which is connected to
QWizardPrivate::_q_updateButtonStates which will re-enable the back button from the
last page.

When the user click "back" and re-open the browser, the account's credentials
already have a oauth token set. So the call to the API to get a new token fails
because we use the previous token instead of using the client's secret_id.
Fix this with the HttpCredentials::DontAddCredentialsAttribute.

Now, this is still not working because the session cookies are confusing the
server. So we'll clear the cookies when re-opening the browser

Author: Christian Kamm
Author Date: 2018-06-18 07:50:11 UTC

fixup: remove outdated Qt5.5 workaround code

Author: Olivier Goffart
Author Date: 2018-06-13 13:15:54 UTC

OAuth2: Try to refresh the token even if the credentials weren't ready.

This can happen when the client is started and the internet connection
was not enabled. Then we would fetch the credentials, but we would
no do the refresh token step (because network is down).
So next time we try to connect, we would also not refresh the token
because the credentials are not marked as 'ready'

Reported in
https://github.com/owncloud/client/issues/6522#issuecomment-396845167

Author: Christian Kamm
Author Date: 2018-06-13 12:20:21 UTC

Ensure GETFileJob notices finishing #6581

It could happen that readyRead was emitted for incoming data while the
download was not yet finished. Then the network job could finish with
no more data arriving - so readyRead wasn't emitted again.

To fix this, the finished signal also gets connected to the readyRead
slot.

Author: Camila Ayres
Author Date: 2018-09-02 10:01:07 UTC

Merge branch 'master' into sync-hidden-files

Author: Christian Kamm
Author Date: 2018-05-16 13:58:31 UTC

Wizard: Add a "(recommended)" to the main option #6470

Author: Christian Kamm
Author Date: 2018-04-24 07:52:15 UTC

Show a tray message when a folder watcher becomes unreliable #6119

Author: Camila San
Author Date: 2018-08-19 17:37:21 UTC

Fixes #534: interactions with expiration date and password.

- Fixes call for slot when date is set - it was the password
slot for that.
- Adds QProgressIndicator and function to toggle animation.
- Fixes: when date was set, the date was not being correctly set and
displayed.
- Fixes: hides and 'deletes' passsword and expire. date widgets when
the user unchecks it in the toolbox menu.

Signed-off-by: Camila San <hello@camila.codes>

Author: Camila San
Author Date: 2018-08-21 12:54:10 UTC

Removes dynamic cast when building navigation apps.

- It checks for the menu title to know where to add the apps menu instead of trying to cast
the menu pointer saved in the sender() property.
- The previous solution was not working reliably - see #523
- Adds TODO.

Signed-off-by: Camila San <hello@camila.codes>

Author: Roeland Jago Douma
Author Date: 2018-07-31 07:34:11 UTC

Revert "allow to switch to the integrated gpu on MacOS"

Author: Camila San
Author Date: 2018-07-10 15:11:34 UTC

Cleans up comments.

Signed-off-by: Camila San <hello@camila.codes>

Author: Julius Haertl
Author Date: 2018-07-04 07:03:22 UTC

Debug failing meson

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Author: Roeland Jago Douma
Author Date: 2018-07-02 19:11:25 UTC

Set Accept-language header for webview requests

This way the server will properly translate it for you if it has
translations.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Author: Nextcloud bot
Author Date: 2018-07-03 00:44:23 UTC

[tx-robot] updated from transifex

Author: Camila Ayres
Author Date: 2018-07-02 10:27:29 UTC

Merge branch 'master' into upstream/pr/6470

Author: Julius Haertl
Author Date: 2018-06-22 10:13:04 UTC

Hide decrypt option since it does only work for empty folders

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Author: Olivier Goffart
Author Date: 2018-05-30 14:29:29 UTC

PropagateDownload: Don't discard the body of error message

We want to keep the body so we can get the message from it
(Issue #6459)

TestDownload::testErrorMessage did not fail because the FakeErrorReply
did not emit readyRead and did not implement bytesAvailable.

Author: Christian Kamm
Author Date: 2018-02-20 16:28:54 UTC

Partial local discovery: Fix scheduling logic

A recent patch that touched the condition for deciding whether a
periodic full local discovery is necessary accidentally inverted the
condition.

Author: Christian Kamm
Author Date: 2018-02-16 09:33:35 UTC

SyncJournal: Clear etag filter before sync

Before, we only cleared the _avoidReadFromDbOnNextSyncFilter *after* a
sync which meant that we had to sync twice after selective sync setup.

Now, we clear the filter *before* a sync as well which allows the actual
next sync to write the correct etags to the db again - instead of only
the sync after that one.

Also expand on comments and rename _avoidReadFromDbOnNextSyncFilter to
_etagStorageFilter.

Author: Christian Kamm
Author Date: 2018-04-12 09:42:11 UTC

Share dialog: Don't hide account settings before showing #6185

At least on windows and linux. OSX would need tests first since
the addition was originally supposed to help with OSX problems,
see #3783.

Author: Christian Kamm
Author Date: 2018-04-17 07:58:57 UTC

Upload: Add more chunk resuming unit tests #6405

Author: Christian Kamm
Author Date: 2018-01-23 13:11:20 UTC

Tray: Change icon for unresolved conflicts #6277

Author: Camila San
Author Date: 2018-04-11 13:20:41 UTC

Only updates the list of apps when there is a change in the server (not 304 status).

Signed-off-by: Camila San <hello@camila.codes>

Author: Camila San
Author Date: 2018-03-09 13:33:04 UTC

Adds 'More information' link to notification instead of action button.

Signed-off-by: Camila San <hello@camila.codes>

Author: Camila San
Author Date: 2018-01-24 14:13:19 UTC

Changes response parsing for the new request.

Signed-off-by: Camila San <hello@camila.codes>

Author: Christian Kamm
Author Date: 2018-01-23 10:47:23 UTC

Nautilus integration: Work with python2 and python3

Author: Markus Goetz
Author Date: 2017-12-20 15:03:02 UTC

VERSION.cmake: 2.4.0 final