neutron

  1. Bug #1374663
  2. Comment #11

Comment 11 for bug 1374663

Revision history for this message
Corey Bryant (corey.bryant) wrote : Re: agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

Shane,

Thanks for the patch. Just a few minor comments:
* did you mean to bump concurrency to 16? it's probably fine since it's just for running tests. just want to make sure it doesn't lock up the next dev's machine. :)
* if it's possible to cherry-pick this patch from the next higher available upstream release branch/tag (> icehouse) then I'd prefer you did that (git checkout icehouse-eol; git cherry-pick -x uuid of commit).
* also relevant patch headers should be added: http://packaging.ubuntu.com/html/patches-to-packages.html#patch-headers

Thanks,
Corey