Comment 4 for bug 1237981

Revision history for this message
Adam Bishop (adam-omega) wrote :

Valgrind trace below, it looks like the fix you've committed matches valgrinds output.

user@debian:~$ valgrind --leak-check=full ssh localhost
==18501== Memcheck, a memory error detector
==18501== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==18501== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info
==18501== Command: ssh localhost
==18501==
==18501== Warning: invalid file descriptor 1024 in syscall close()
==18501== Warning: invalid file descriptor 1025 in syscall close()
==18501== Warning: invalid file descriptor 1026 in syscall close()
==18501== Use --log-fd=<number> to select an alternative log fd.
==18501== Warning: invalid file descriptor 1027 in syscall close()
==18501== Warning: invalid file descriptor 1028 in syscall close()
==18501== Warning: invalid file descriptor 1029 in syscall close()
==18501== Invalid free() / delete / delete[] / realloc()
==18501== at 0x482750C: free (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==18501== by 0x4C49591: krb5_free_principal (in /usr/lib/i386-linux-gnu/libkrb5.so.3.3)
==18501== by 0x5177F16: gssEapReleaseName (in /usr/lib/i386-linux-gnu/gss/mech_eap.so)
==18501== by 0x4DD2BD7: ???
==18501== Address 0x4debaa0 is 0 bytes inside a block of size 1 free'd
==18501== at 0x482750C: free (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==18501== by 0x4C49FCE: krb5_free_unparsed_name (in /usr/lib/i386-linux-gnu/libkrb5.so.3.3)
==18501== by 0x51706F6: ??? (in /usr/lib/i386-linux-gnu/gss/mech_eap.so)
==18501== by 0x517BF8C: gssEapSmStep (in /usr/lib/i386-linux-gnu/gss/mech_eap.so)
==18501== by 0x5170857: gssEapInitSecContext (in /usr/lib/i386-linux-gnu/gss/mech_eap.so)
==18501== by 0x5170C51: gss_init_sec_context (in /usr/lib/i386-linux-gnu/gss/mech_eap.so)
==18501== by 0x4A635A5: gss_init_sec_context (in /usr/lib/i386-linux-gnu/libgssapi_krb5.so.2.2)
==18501== by 0x14D803: ??? (in /usr/bin/ssh)
==18501==