Author: Oleksandr "Sanja" Byelkin
Author Date: 2018-11-20 09:58:34 UTC

MDEV-15073: Generic UDAF parser code in server for windows functions

Added support for usual agreggate UDF (UDAF)
Added remove() call support for more efficient window function processing
Added example of aggregate UDF with efficient windows function support

Author: Sergey Petrunia
Author Date: 2018-11-01 08:35:28 UTC

MDEV-17518: Range optimization doesn't use ON expressions from nested outer joins

Part#2: take into account that join nest that we are marking as constant
might already have constant tables in it. Don't count these tables twice.

Author: Marko Mäkelä
Author Date: 2018-10-19 16:00:25 UTC

Merge 10.4 into 10.4-mdev-15562

This branch exists just for the record, for preserving the
development history, should it ever be needed.

Author: Larysa Sherepa
Author Date: 2018-10-18 16:46:00 UTC

CTE tests

Author: Vicențiu Ciorbaru
Author Date: 2018-10-14 17:54:52 UTC

Merge branch 'MDEV1732_check_constraint_10.2_v1' of https://github.com/an3l/server into an3l-MDEV1732_check_constraint_10.2_v1

Author: Igor Babaev
Author Date: 2018-10-10 11:40:30 UTC

MDEV-17382 Hash join algorithm should not be used to join materialized
           derived table / view by equality

Now rows of a materialized derived table are always put into a
temporary table before join operation. If BNLH is used to join this
table with the result of a partial join then both operands of the
join are actually put into main memory. In most cases this is not
efficient.
We could avoid this by sending the rows of the derived table directly
to the join operation. However this kind of data flow is not supported
yet.
Fixed by not allowing usage of hash join algorithm to join a materialized
derived table if it's joined by an equality predicate of the form
f=e where f is a field of the derived table.

Adjusted the results of the test case for 10.2-compatibility.

Author: Vicențiu Ciorbaru
Author Date: 2018-09-22 11:01:46 UTC

Small change for feedback debug

Author: Sachin Setiya
Author Date: 2018-09-17 07:16:24 UTC

multiple_user_binlog

Author: Monty
Author Date: 2018-09-05 17:20:16 UTC

Added DBUG_ASSERT_AS_PRINTF to BUILD/..asan-max

Author: Otto Kekäläinen
Author Date: 2018-09-02 19:36:14 UTC

WIP: test 6

Author: Sergey Petrunia
Author Date: 2018-09-01 12:10:50 UTC

Trigger another BB run

Author: Oleksandr "Sanja" Byelkin
Author Date: 2018-08-16 11:55:36 UTC

MDEV-16930: Crash when VALUES in derived table contains expressions

Give names to the value constructor columns as in SELECT-list.

Author: Vicențiu Ciorbaru
Author Date: 2018-07-30 15:34:12 UTC

Fix tmp table patch

Author: Andrei Elkin
Author Date: 2018-07-28 09:15:05 UTC

MDEV-14014 Unittest extension to cover concurrent IO_CACHE read and write by the dump and user threads.

Author: Sergey Petrunia
Author Date: 2018-07-13 13:23:04 UTC

MDEV-16710, Issue#857: MyRocks: Incorrect behavior when miltiple statements fail inside a transaction

rollback_to_stmt_savepoint() calls do_rollback_to_savepoint(). This removes
the changes made by this statement, and also removes the set savepoint.

Before we start processing the next statement, we need to set the new
savepoint, so we will have something to rollback to if the next statement
fails.

Since rollback_to_stmt_savepoint always sets a new savepoint now,
m_n_savepoints is now redundant and is removed.

Author: Jacob Mathew
Author Date: 2018-07-09 21:25:37 UTC

MDEV-16246: insert timestamp into spider table from mysqldump gets wrong time zone.

The problem occurred because the Spider node was incorrectly handling
timestamp values sent to and received from the data nodes.

The problem has been corrected as follows:
- Added logic to set and maintain the UTC time zone on the data nodes.
  To prevent timestamp ambiguity, it is necessary for the data nodes to use
  a time zone such as UTC which does not have daylight savings time.
- Removed the spider_sync_time_zone configuration variable, which did not
  solve the problem and which interfered with the solution.
- Added logic to convert to the UTC time zone all timestamp values sent to
  and received from the data nodes. This is done for both unique and
  non-unique timestamp columns. It is done for WHERE clauses, applying to
  SELECT, UPDATE and DELETE statements, and for UPDATE columns.
- Disabled Spider's use of direct update when any of the columns to update is
  a timestamp column. This is necessary to prevent false duplicate key value
  errors.
- Added a new test spider.timestamp to thoroughly test Spider's handling of
  timestamp values.

Author:
  Jacob Mathew.

Reviewer:
  Kentoku Shiba.

Author: Anel Husaković
Author Date: 2018-05-15 11:17:43 UTC

MDEV-12914: Disable silently call of myisam

Author: Anel Husaković
Author Date: 2018-04-03 12:41:13 UTC

MDEV-14474 information_schema.check_constraints

Implement according to standard SQL specification 2008.
The check_constraints table is used for fetching metadata about
the constraints defined for tables in all databases.

There were some result files which failed after running mtr.
These files are updated with newly create record with mtr --record.

Author: Vladislav Vaintroub
Author Date: 2018-06-29 21:18:47 UTC

MDEV-16596 : Windows - redo log does not work on native 4K sector disks.

Disks with native 4K sectors need 4K alignment and size for unbuffered IO
(i.e files opened with FILE_FLAG_NO_BUFFERING)

Innodb opens redo log with FILE_FLAG_NO_BUFFERING, but it does 512byte IOs
Thus, the IO fails, and Innodb is non-functional.

The fix is to check whether OS_FILE_LOG_BLOCK_SIZE is multiple of logical
sector size, and if it is not, reopen the redo log without
FILE_FLAG_NO_BUFFERING flag.

Author: Marko Mäkelä
Author Date: 2018-02-23 20:26:26 UTC

MDEV-15058: Allocate buf_pool statically

buf_pool_t::create(): Replaces buf_pool_init().

buf_pool_t::close(): Replaces buf_pool_free().

FIXME: Do not add buf_pool_t::is_initialised()

Author: Sachin Setiya
Author Date: 2018-05-14 06:45:38 UTC

MDEV-14472 Assertion `is_current_stmt_binlog_format_row()' failed...
in THD::binlog_write_table_map

Problem:- So the issue is when the test case (mdev_14472) is run with debug
  build , Assert DBUG_ASSERT(is_current_stmt_binlog_format_row()); is fired
  in binlog_write_table_map.

Analysis:- When we lock table t1, and if t1 has some trigger which updates
  another table then all other tables are also locked. So in the case of lock
  t1(in mdev_14472 test case) we will lock t1, t2, t3 and t4. In next insert
  command (t2 insert), we call handler->check_table_row_based from
  write_locked_table_maps which updates the table handler
  check_table_binlog_row_based_done to 1 and check_table_binlog_row_based_result
  to 1 , it is set to one because this particular insert stmt is unsafe(because
  of trigger on t4). The next insert stmt(insert t3) is safe so we will write
  that in stmt format , but since we havent cleared the previous
  check_table_binlog_row_based_result so it is logged in row format while
  thd->is_current_stmt_binlog_format_row() is still 0, and this fires the
  assert. So the question is why check_table_binlog_row_based_result is not
  reseted because mark_used_tables_as_free_for_reuse skips locked tables

Solution:- We make mark_used_tables_as_free_for_reuse to reset
  check_table_binlog_row_based_result even when table is locked

Author: Sergey Vojtovich
Author Date: 2018-06-05 08:54:06 UTC

MDEV-16371 - Fix for memory write order inversion

my_atomic implementation for interruptable waits.

Author: Oleksandr "Sanja" Byelkin
Author Date: 2018-05-17 17:17:28 UTC

MDEV-12465: Server crashes in my_scan_weight_utf8_bin upon collecting stats for RocksDB table

Do not use "only index read" in analyzing indices if there is a field which present in the index only partially.

Author: THIRUNARAYANAN BALATHANDAYUTHAPANI
Author Date: 2018-05-15 05:46:51 UTC

MDEV-13626 Merge InnoDB test cases from MySQL 5.7

Imported the following test case from mysql to MariaDB

1) innodb.alter_kill
2) innodb.alter_foreign_crash
3) innodb.alter_rename_files
4) innodb.analyze_table
5) Appended the case in innodb-online-alter-gis

Author: Sachin Setiya
Author Date: 2018-05-14 06:45:38 UTC

MDEV-14472 Assertion `is_current_stmt_binlog_format_row()' failed...
in THD::binlog_write_table_map

try 1 patch

Author: Sergey Petrunia
Author Date: 2018-05-11 11:50:36 UTC

Tentatively enable a few myrocks tests

Author: Oleksandr "Sanja" Byelkin
Author Date: 2018-04-26 17:58:43 UTC

MDEV-13024: Server crashes in my_store_ptr upon DELETE from sequence in multi-table format

Make operation possition() dummy for sequences (should not be used really)

Author: Vicențiu Ciorbaru
Author Date: 2018-04-02 21:07:58 UTC

Force build?

Author: Oleksandr "Sanja" Byelkin
Author Date: 2018-03-27 06:42:31 UTC

Walking throuch query tables ON expression added.

Author: Michael Widenius
Author Date: 2018-03-15 10:31:59 UTC

Added flush tables to acl_load_mutex-5170.test

This is needed as otherwise a lot of MyISAM tables may be marked
as crashed, depending on in which order tests are run

Author: Sergey Petrunia
Author Date: 2018-03-08 10:43:55 UTC

MDEV-15245: Assertion `false' failed in myrocks::ha_rocksdb::position

Don't call handler->position() if the last call to read a row did
not succeed.

Author: Marko Mäkelä
Author Date: 2018-02-24 20:04:11 UTC

Merge 10.3 into bb-10.3-MDEV-15058

Author: Jacob Mathew
Author Date: 2018-02-20 03:19:03 UTC

MDEV-14500: Support engines without rnd_pos() and
            engines with inefficient rnd_pos()

Some engines have not implemented rnd_pos(). There are other engines whose
implementation of rnd_pos() is inherently inefficient. Spider is such an
engine, whose implementation of rnd_pos() needs to access a table on a remote
data node to retrieve a single table row.

To address these limitations, a new temporary table has been added to filesort.
When filesort sequentially reads the table being sorted, each row is written to
the filesort temp table in addition to being copied to the sort buffer.
Subsequent calls to rnd_pos() will then access the table row in the filesort
temp table instead of in the table being sorted.

The following logic changes incorporate the new filesort temp table into the
server:
- A new handler method to determine whether a call to the engine's
  rnd_pos() is expensive. The default return value is FALSE. Engines without
  rnd_pos() or with an inefficient rnd_pos() should return TRUE.
- Create the filesort temp table only if:
  - There are no add-on columns for filesort; and
  - The engine's implementation of rnd_pos() is expensive.
- Write to the temp table each row that is read from the table being sorted.
- Do subsequent row retrievals that use rnd_pos() on the temp table instead of
  on the table being sorted. Upon retrieving a row from the temp table, copy
  its column values to the record of the table being sorted.
- Upon completion of retrieval of the sorted result rows, delete the filesort
  temp table and free the memory allocated for using it.

The logic changes are in the following areas:
- Table handler.
- Partition engine.
- Spider engine.
- Filesort.
- Read record manager.

Note that these changes only address the use of rnd_pos() by filesort. They do
not address the use of rnd_pos() in other areas such as:
- Quick select.
- Insert.
- Update.
- Window functions.
- Multi Range Read.

Author:
  Jacob Mathew.

Reviewer:
  Sergei Golubchik.

Author: Monty
Author Date: 2018-02-19 09:23:20 UTC

Move alter partition flags to alter_info->partition_flags

This is done to get more free flag bits for alter_info->flags

Renamed all ALTER PARTITION defines to start with ALTER_PARTITION_
Renamed ALTER_PARTITION to ALTER_PARTITION_INFO
Renamed ALTER_TABLE_REORG to ALTER_PARTITION_TABLE_REORG

Other things:
- Shifted some ALTER_xxx defines to get empty bits at end

Author: Monty
Author Date: 2018-02-10 12:42:59 UTC

Added Max_index_length and Temporary to SHOW TABLE STATUS

- Max_index_length is supported by MyISAM and Aria tables.
- Temporary is a placeholder to signal that a table is a
  temporary table. For the moment this is always "N", except
  "Y" for generated information_schema tables and NULL for
  views. Full temporary table support will be done in another task.
  (No reason to have to update a lot of result files twice in a row)

Author: Sergey Petrunia
Author Date: 2018-01-13 22:22:54 UTC

Merge remote-tracking branch 'origin/10.2' into bb-10.3-mariarocks

Author: Vicențiu Ciorbaru
Author Date: 2018-01-12 01:57:02 UTC

To avoid travis network timeouts, use travis's retry script

Author: Vicențiu Ciorbaru
Author Date: 2018-01-09 07:05:48 UTC

Workaround for dtoa.c

There is no obvious reason why multiplying by 1.0 helps solve a
precision problem on gcc-7 or clang-5, but it does work. Casting to
ulong however makes the problem come up again. Windows warns about loss
of precision, so to quiet warnings until an appropriate fix is
implemented, ifdef 2 versions of the code.

Author: Vicențiu Ciorbaru
Author Date: 2017-12-30 15:18:24 UTC

Tentative fix for travis

This undoes a lock-unlock for LOCK_thread_count.

Author: Monty
Author Date: 2017-12-02 19:50:08 UTC

Remove compiler warnings

Author: Andrei Elkin
Author Date: 2017-11-27 19:06:17 UTC

MDEV-13073. This patch is a followup of the previous one to convert the trailing underscore identifier to mariadb standard. For identifier representing class private members the underscore is replaced with a `m_` prefix. Otherwise `_` is just removed.

Author: Andrei Elkin
Author Date: 2017-11-16 19:14:59 UTC

MDEV-13073. Fixed failing on BB sys_vars.rpl_semi_sync_master_enabled_basic. The issue forced to add up aan argument to THD::THD and THD::init to propagate skip of a mutex locking. The lock could not be released instead as this leads to clear deadlock; the test is received a piece for concurrent ack thread start/stop.

Author: Jun Su
Author Date: 2017-10-25 09:41:23 UTC

Support CRC32 SSE2 implementation under Windows

Author: Larysa Sherepa
Author Date: 2017-11-14 22:22:09 UTC

innodb tests 563

Author: Vicențiu Ciorbaru
Author Date: 2017-11-13 06:05:34 UTC

Implement File Descriptor Plugin

Made use of /proc filesystem to get list of open file descriptors.
This is implemented as a Information_Schema plugin table PROC_FDINFO.

Author: Jacob Mathew
Author Date: 2017-10-14 22:24:24 UTC

Adding direct update/delete to the server and to the partition engine.

Contains Spiral patches:
- Spiral Patch 006: 006_mariadb-10.2.0.direct_update_rows.diff MDEV-7704
- Spiral Patch 008: 008_mariadb-10.2.0.partition_direct_update.diff MDEV-7706
- Spiral Patch 010: 010_mariadb-10.2.0.direct_update_rows2.diff MDEV-7708
- Spiral Patch 011: 011_mariadb-10.2.0.aggregate.diff MDEV-7709
- Spiral Patch 027: 027_mariadb-10.2.0.force_bulk_update.diff MDEV-7724
- Spiral Patch 061: 061_mariadb-10.2.0.mariadb-10.1.8.diff MDEV-12870

- Add support for direct update and direct delete requests. A direct
  update/delete request handles all qualified rows in a single operation,
  rather than one row at a time.

- This commit has the following differences compared to the original patches:
  - Most of the parameters of the new functions are unnecessary. The
    unnecessary parameters have been removed.
  - Changed bit positions for new handler flags upon consideration of
    handler flags not needed by other Spiral patches and handler flags
    merged from MySQL.

Author: Oleksandr "Sanja" Byelkin
Author Date: 2017-11-06 10:23:32 UTC

MDEV-9059: protocol: bundle first command with the authentication packet

Author: Sergey Vojtovich
Author Date: 2017-10-31 11:14:29 UTC

PROC_FDINFO plugin for workshop

Author: Larysa Sherepa
Author Date: 2017-10-31 09:20:00 UTC

deleted wl6501/(they are relevant only from 10.2.2)

Author: Sergey Vojtovich
Author Date: 2017-10-06 10:03:03 UTC

Workshop plugin

Author: Marko Mäkelä
Author Date: 2017-10-06 06:51:14 UTC

Merge 10.3 into 10.3-instant

The tree state corresponds to the squashed
commit a4948dafcd7eee65f16d848bdc6562fc49ef8916 in the 10.3 branch.

This branch is preserved for future reference.

Author: Jacob Mathew
Author Date: 2017-09-20 22:05:34 UTC

Adding direct update/delete to the server and to the partition engine.

Contains Spiral patches:
- Spiral Patch 006: 006_mariadb-10.2.0.direct_update_rows.diff MDEV-7704
- Spiral Patch 008: 008_mariadb-10.2.0.partition_direct_update.diff MDEV-7706
- Spiral Patch 010: 010_mariadb-10.2.0.direct_update_rows2.diff MDEV-7708
- Spiral Patch 011: 011_mariadb-10.2.0.aggregate.diff MDEV-7709
- Spiral Patch 027: 027_mariadb-10.2.0.force_bulk_update.diff MDEV-7724
- Spiral Patch 061: 061_mariadb-10.2.0.mariadb-10.1.8.diff MDEV-12870

- Add support for direct update and direct delete requests. A direct
  update/delete request handles all qualified rows in a single operation,
  rather than one row at a time.

- This patch has the following differences compared to the original patch:
  - Most of the parameters of the new functions are unnecessary. The
    unnecessary parameters have been removed.
  - Changed bit positions for new handler flags upon consideration of
    handler flags not needed by other Spiral patches.

Author: Monty
Author Date: 2017-09-29 14:48:32 UTC

Fix index scan cleanup in the partition engine.

Spiral Patch 057: 057_mariadb-10.2.0.partition_index_end.diff MDEV-12999

Original author: Kentoku SHIBA
First reviewer: Jacob Mathew
Second reviewer: Michael Widenius

Author: Sergey Petrunia
Author Date: 2017-09-11 15:15:58 UTC

MDEV-11934: MariaRocks: Group Commit with binlog

Implement MariaDB's Group Commit API. This is a first attempt which lacks
the expected performance.

Author: Sergey Petrunia
Author Date: 2017-07-25 06:32:00 UTC

A dummy change to force a buildbot re-run

Author: Sergey Petrunia
Author Date: 2017-07-21 15:02:53 UTC

MDEV-13355: Assertion `using_unique_constraint || group_buff <= param->group_buff...

The code in OIN::optimize_inner() has this call

   calc_group_buffer(this, group_list)

the call is however bypassed when the optimizer figures out that the JOIN
has "Impossible WHERE".

If we attempt to calculate the value of a window function afterwards,
we will get a crash when trying to create a temporary table.

So, put a call to calc_group_buffer() here as well. It's a bit surprising
that all these steps are done for a query that will produce zero rows
but we are just following the approach taken by the fix for mdev-11999
here.

Author: Sergey Petrunia
Author Date: 2017-07-16 08:28:15 UTC

MDEV-13330: ANALYZE FORMAT=JSON should print time spent in SPs

- More test coverage

Author: Vicențiu Ciorbaru
Author Date: 2017-07-12 18:31:14 UTC

Rename mariadb-backup-10.2.files to mariadb-backup-10.2.install

.files extension is not used by debian packaging, .install is.

Author: Vicențiu Ciorbaru
Author Date: 2017-06-13 13:54:40 UTC

MDEV-10879: Window Functions final ordering of result set

Window functions now force an ordering to the result set if none is
specified through order by. The ordering that will be returned is the final ordering
that is used during window function computation. For multiple window functions,
it should generally be the most specific sort ordering for the final
window function in the select list.

Author: Jacob Mathew
Author Date: 2017-06-29 01:42:20 UTC

MDEV-7914 spider/bg.ha, spider/bg.ha_part fail sporadically in buildbot

Fixed the problem by adding a Spider shutdown indicator and a Spider memory
lock. Spider shutdown acquires the lock for write access and
all other requestors acquire the lock for read access.

Author: Sergey Petrunia
Author Date: 2017-06-26 15:29:30 UTC

MDEV-12179: Per-engine mysql.gtid_slave_pos tables

Merge to 10.3
- changed a few LEX_STRING to LEX_CSTRING