View Bazaar branches
Get this repository:
git clone https://git.launchpad.net/maria

MariaDB has 18 active reviews.

Branches

Name Last Modified Last Commit
bb-10.5-wlad-15053 2020-03-09 19:44:56 UTC 2020-03-09
Fix comments in buf_read_page

Author: Vladislav Vaintroub
Author Date: 2020-03-09 19:44:56 UTC

Fix comments in buf_read_page

bb-10.5-pre_mdev-742 2020-03-09 15:33:07 UTC 2020-03-09
MDEV-21659 XA rollback foreign_xid is allowed inside active XA

Author: Andrei Elkin
Author Date: 2020-03-02 15:12:35 UTC

MDEV-21659 XA rollback foreign_xid is allowed inside active XA
MDEV-21854 xa commit `xid` one phase for already prepared transaction must always error out

Added state and one-phase option checks to XA "external" commit/rollback
branches. While the XA standard does not prohibit it,
Commit and Rollback of an XA external to the current ongoing transaction
is not allowed; after all the current transaction may rollback
to not being able to revert that decision.

bb-10.2-MDEV-21758 2020-03-09 07:00:14 UTC 2020-03-09
MDEV-21758 : Events switched randomly to SLAVESIDE_DISABLED

Author: Jan Lindström
Author Date: 2020-03-09 07:00:14 UTC

MDEV-21758 : Events switched randomly to SLAVESIDE_DISABLED

Change events only on Galera environment where idea is that
event is enabled only on one node of the cluster and nodes
are identified by server_id.

10.5-mdev21784-reg1-vfuncs 2020-03-08 21:29:48 UTC 2020-03-08
MDEV-21784: Performance testing for packed sort keys

Author: Sergey Petrunia
Author Date: 2020-03-08 21:29:48 UTC

MDEV-21784: Performance testing for packed sort keys

A piece of cumulative patch for

  MDEV-21580 Allow packed sort keys in sort buffer

which just adds some virtual functions (without any calls to them)

10.5-marko 2020-03-06 13:21:57 UTC 2020-03-06
WIP clean up log upgrade

Author: Marko Mäkelä
Author Date: 2020-03-06 13:21:57 UTC

WIP clean up log upgrade

FIXME: innodb.log_corruption fails with result diff,
and fails to delete ib_logfile1. But it no longer crashes!

10.4-monty 2020-03-06 12:21:20 UTC 2020-03-06
Second stage of optimizer_trace optimizations

Author: Monty
Author Date: 2020-03-06 12:21:20 UTC

Second stage of optimizer_trace optimizations

- Move testing of my_writer to inline functions to avoid calls
- Made more functions inline. Especially thd->thread_started()
  is now very optimized!
- Moved Opt_trace_stmt classe to opt_trace_context.h to get critical
  functions inline

bb-10.4-robert 2020-03-05 16:16:00 UTC 2020-03-05
auth_gssapi: fix include path for Solaris

Author: Daniel Black
Author Date: 2019-09-26 22:43:10 UTC

auth_gssapi: fix include path for Solaris

tested on:
$ uname -a
SunOS openindiana 5.11 illumos-b97b1727bc i86pc i386 i86pc

bb-10.5-MDEV-21534 2020-03-01 18:02:21 UTC 2020-03-01
MDEV-21534 - Improve innodb redo log group commit performance

Author: Vladislav Vaintroub
Author Date: 2020-02-07 21:12:35 UTC

MDEV-21534 - Improve innodb redo log group commit performance

Introduce special synchronization primitive group_commit_lock
for more efficient synchronization of redo log writing and flushing.

The goal is to reduce CPU consumption on log_write_up_to, to reduce
the spurious wakeups, and improve the throughput in write-intensive
benchmarks.

bb-MDEV-21841 2020-02-28 17:02:27 UTC 2020-02-28
MDEV-21841 CONV() function doesn't truncate its output to 21 when uses defaul...

Author: Roman Nozdrin
Author Date: 2020-02-28 15:44:56 UTC

MDEV-21841 CONV() function doesn't truncate its output to 21 when uses default charset.

10.5-mdev21784-reg1-base 2020-02-28 09:45:51 UTC 2020-02-28
MDEV-21838: Add information about packed addon fields in ANALYZE FORMAT=JSON

Author: varun
Author Date: 2020-02-28 06:16:13 UTC

MDEV-21838: Add information about packed addon fields in ANALYZE FORMAT=JSON

It is useful to know whether sorting uses addon fields[packed|unpacked] or ROWID.
Provide this information in ANALYZE FORMAT=JSON output.

bb-10.5-MDEV-14479-table-locks 2020-02-27 23:12:00 UTC 2020-02-27
MDEV-14479: Do not acquire InnoDB record locks when covering table locks

Author: Vlad Lesin
Author Date: 2020-02-24 19:17:16 UTC

MDEV-14479: Do not acquire InnoDB record locks when covering table locks
exist

lock_rec_lock() does not set record lock if table lock is stronger or
equal to the acquired record lock.

bb-10.3-anel-PR796 2020-02-26 14:47:05 UTC 2020-02-26
Drop temporary table and base table with the same name

Author: Anel Husakovic
Author Date: 2018-06-12 15:07:39 UTC

Drop temporary table and base table with the same name

bb-10.5-midenok-MDEV-16417 2020-02-26 13:48:31 UTC 2020-02-26
Compilation fixes (other)

Author: midenok
Author Date: 2020-02-13 08:46:40 UTC

Compilation fixes (other)

bb-10.5-MDEV-16983-period-fk 2020-02-26 08:27:16 UTC 2020-02-26
Period: add versioning combination

Author: Nikita Malyavin
Author Date: 2020-01-21 09:48:47 UTC

Period: add versioning combination

nm/versioning-combinatoin 2020-02-26 08:27:16 UTC 2020-02-26
Period: add versioning combination

Author: Nikita Malyavin
Author Date: 2020-01-21 09:48:47 UTC

Period: add versioning combination

bb-10.3-anel-PR802 2020-02-25 14:57:50 UTC 2020-02-25
Added CF_HA_CLOSE flag for RENAME_TABLE

Author: Anel Husakovic
Author Date: 2018-06-05 13:35:43 UTC

Added CF_HA_CLOSE flag for RENAME_TABLE

bb-10.5-MDEV-14479-table-locks-lock_rec_has_expl 2020-02-25 12:16:37 UTC 2020-02-25
MDEV-14479: Do not acquire InnoDB record locks when covering table locks

Author: Vlad Lesin
Author Date: 2020-02-25 10:05:41 UTC

MDEV-14479: Do not acquire InnoDB record locks when covering table locks
exist

Check table locks in lock_rec_has_expl().

bb-10.5-galera 2020-02-21 09:57:29 UTC 2020-02-21
Disable galera_as_slave_gtid_replicate_do_db_cc because it crashes.

Author: Jan Lindström
Author Date: 2020-02-21 09:57:29 UTC

Disable galera_as_slave_gtid_replicate_do_db_cc because it crashes.

bb-10.4-MDEV-20494 2020-02-20 08:42:27 UTC 2020-02-20
MDEV-20494 ER_NOT_FORM_FILE or Assertion `!is_set() || (m_status == DA_OK_BUL...

Author: Nikita Malyavin
Author Date: 2020-02-20 08:42:27 UTC

MDEV-20494 ER_NOT_FORM_FILE or Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' failed upon adding partition to a versioned table

Problem: fast_alter_partition_table tries to write the shadow frm with zero-length period constraint name. In case of explicit write-lock table reopens and shadow frm is read. Period constraint name is saved to frm in format "zero means two bytes more" (see extra2_write_str/extra2_read_len), so zero value here corrupts frm.

Solution: generate constraint names before fast_alter_partition_table is issued

bb-10.0-MDEV-6463 2020-02-19 19:46:29 UTC 2020-02-19
Merge tag 'mariadb-5.5.67' into 10.0

Author: Sergei Golubchik
Author Date: 2020-02-19 19:46:29 UTC

Merge tag 'mariadb-5.5.67' into 10.0

10.0 2020-02-19 19:46:29 UTC 2020-02-19
Merge tag 'mariadb-5.5.67' into 10.0

Author: Sergei Golubchik
Author Date: 2020-02-19 19:46:29 UTC

Merge tag 'mariadb-5.5.67' into 10.0

bb-10.3-MDEV-17091 2020-02-18 07:29:44 UTC 2020-02-18
Assertion `old_part_id == m_last_part' failed in ha_partition::update_row or ...

Author: Nikita Malyavin
Author Date: 2019-03-04 09:09:30 UTC

Assertion `old_part_id == m_last_part' failed in ha_partition::update_row or `part_id == m_last_part' in ha_partition::delete_row upon UPDATE/DELETE after dropping versioning

PRIMARY KEY change hadn't been treated as partition reorganization in case of partitioning by KEY() (without parameters).

* set `*partition_changed= true` in the described case.
* since add/drop system versioning does not affect alter_info->key_list, it required separate attention

bb-10.5-MDEV-15053 2020-02-17 18:56:50 UTC 2020-02-17
MDEV-15053 : make buf_buddy_stat_t use atomics

Author: Vladislav Vaintroub
Author Date: 2020-02-17 18:56:50 UTC

MDEV-15053 : make buf_buddy_stat_t use atomics

bb-10.3.16-MDEV-21109-wrong-page-no-assert 2020-02-16 13:42:46 UTC 2020-02-16
Add some extra logging to catch the case when page is written with wrong offset.

Author: Vlad Lesin
Author Date: 2019-11-27 22:16:22 UTC

Add some extra logging to catch the case when page is written with wrong offset.

bb-10.3.16-MDEV-21109-wrong-page-no-log 2020-02-16 13:36:22 UTC 2020-02-16
Add some extra logging to catch the case when page is written with wrong offset.

Author: Vlad Lesin
Author Date: 2019-11-27 22:16:22 UTC

Add some extra logging to catch the case when page is written with wrong offset.

10.5-mdev61 2020-02-14 15:46:08 UTC 2020-02-14
bump the VERSION

Author: Daniel Bartholomew
Author Date: 2020-02-14 15:46:08 UTC

bump the VERSION

bb-10.4-galera 2020-02-14 06:20:52 UTC 2020-02-14
Fix Galera test galera_as_slave_ctas.

Author: Jan Lindström
Author Date: 2020-02-14 06:20:52 UTC

Fix Galera test galera_as_slave_ctas.

bb-10.2-MDEV-21446 2020-02-12 08:32:30 UTC 2020-02-12
MDEV-21556 : galera.lp1376747-4 MTR failed: Result length mismatch

Author: Jan Lindström
Author Date: 2020-02-12 08:32:30 UTC

MDEV-21556 : galera.lp1376747-4 MTR failed: Result length mismatch

Add proper wait condition instead of sleeps.

bb-10.5-MDEV-20051 2020-02-11 08:25:07 UTC 2020-02-11
Fix typo.

Author: Jan Lindström
Author Date: 2020-02-11 08:25:07 UTC

Fix typo.

10.5-mdev8306-2 2020-02-09 15:02:03 UTC 2020-02-09
Fixing optimizer trace tests failing

Author: varun
Author Date: 2020-02-09 15:02:03 UTC

Fixing optimizer trace tests failing

bb-10.3-MDEV-21601 2020-02-07 12:27:51 UTC 2020-02-07
MDEV-21667 : Galera test failure on MW-336

Author: Jan Lindström
Author Date: 2020-02-07 12:18:17 UTC

MDEV-21667 : Galera test failure on MW-336

Problem seems to be the fact that we did not enforce correct
applier thread numbers after every command that effects them.
Test changes only.

bb-10.2-MDEV-21601 2020-02-07 12:18:17 UTC 2020-02-07
MDEV-21667 : Galera test failure on MW-336

Author: Jan Lindström
Author Date: 2020-02-07 12:18:17 UTC

MDEV-21667 : Galera test failure on MW-336

Problem seems to be the fact that we did not enforce correct
applier thread numbers after every command that effects them.
Test changes only.

bb-10.2-elenst 2020-02-06 19:46:25 UTC 2020-02-06
MDEV-21664 Add opt files for have_innodb_Xk.inc

Author: Elena Stepanova
Author Date: 2020-02-06 19:46:25 UTC

MDEV-21664 Add opt files for have_innodb_Xk.inc

bb-10.5-svoj-MDEV-17084-redo 2020-02-04 19:13:15 UTC 2020-02-04
InnoDB redo log IO methods

Author: Sergey Vojtovich
Author Date: 2020-01-21 13:21:20 UTC

InnoDB redo log IO methods

normal - conventional IO using read()/write()/fdatasync()
mmap - memory mapped IO, expected to be faster but less secure

bb-10.4-MDEV-20625 2020-02-04 09:14:21 UTC 2020-02-04
MDEV-20625 : MariaDB asserting when enabling wsrep_on

Author: Jan Lindström
Author Date: 2020-02-04 07:00:36 UTC

MDEV-20625 : MariaDB asserting when enabling wsrep_on

We need to release global system variables mutex before
doing wsrep_init to avoid race with next show status and
we need to save wsrep_on value as it is changed on wsrep_init.
Added test case.

bb-10.3-vicentiu-json-review 2020-02-04 08:16:18 UTC 2020-02-04
Cleanup after review

Author: Anel Husakovic
Author Date: 2020-02-03 18:54:01 UTC

Cleanup after review

bb-10.5-upto 2020-02-03 12:34:31 UTC 2020-02-03
Merge branch 'codership-10.5-galera_sync_wait_upto' into 10.5

Author: Jan Lindström
Author Date: 2020-02-03 12:34:31 UTC

Merge branch 'codership-10.5-galera_sync_wait_upto' into 10.5

bb-10.5-MDEV-21598 2020-01-30 10:20:54 UTC 2020-01-30
Fix compile error on Windows.

Author: Jan Lindström
Author Date: 2020-01-30 10:20:54 UTC

Fix compile error on Windows.

bb-10.5-MDEV-21351 2020-01-29 10:42:45 UTC 2020-01-29
Cleanup: More logical names and member functions

Author: Marko Mäkelä
Author Date: 2020-01-29 10:42:45 UTC

Cleanup: More logical names and member functions

recv_sys_t::free_corrupted_page(): Renamed from recv_recover_corrupt_page().

recv_sys_t::is_memory_exhausted(): Renamed from recv_sys_heap_check().

recv_sys_t::max_blocks(): Accessor for max_log_blocks.

recv_sys_t::blocks: Buffer pool blocks reserved for redo log records.

For the debug functions related to recv_sys_t::alloc(), use the
logical name free().

Rename some variables 'store_to_hash' to 'store', because recv_sys.pages
is not a hash table.

10.2-vicentiu 2020-01-28 15:59:55 UTC 2020-01-28
Move mysqltest.1 man page to test package

Author: Vicentiu Ciorbaru
Author Date: 2020-01-28 15:59:47 UTC

Move mysqltest.1 man page to test package

bb-10.4-andrei 2020-01-27 16:26:01 UTC 2020-01-27
MDEV-7974 XA PREPARE-d transactions survive disconnect/server restart.

Author: Alexey Botchkov
Author Date: 2019-03-30 21:47:28 UTC

MDEV-7974 XA PREPARE-d transactions survive disconnect/server restart.

trans_detach() implemented to survive disconnect.
XA_prepare_log_event added to reflect XA PREPARE in the binlog.

MDEV-7974 review/contribution:
gtid record of XA-prepare should no be merged into the replicated
trx. This patch redirects it into the default mysql.gtid_slave_pos table. A test is added.

MDEV-7974 review/contribution:
part2 (sources code) gtid record of XA-prepare should no be merged into the replicated
trx...

MDEV-7974 XA trnasactions.

XID_STATE::registered_for_binlog is replaced with rw_trans flag
in ha_prepare().

MDEV-7974 XA transactions.

FLUSH TABLES WITH READ LOCK now blocks the XA COMMIT/ROLLBACK/PREPARE
statements as they write to the binlog/Innodb redo.

MDEV-7974 XA transactions.

tokudb_maria.xa test fixed.

MDEV-7974: record_gtid for XA prepared is fixed to exec the gtid statement after the xa trx got prepared and logged.

MDEV-7974

Almost ultimate merge with the XA refactoring (to cover is_binlogged).
todo: test out the master side; etc.

MDEV-7974

Cleanup/refactoring for is_binlogged and applier_reset_xa_trans.
todo: fix the slave side allocation and test.

MDEV-7974

FTWRL && XA ROLLBACK, xa.test is refined/corrected.

MDEV-7974: slave side groupping with XA_prepare, mixed engines and few mtr tests update with 5.7 are added.

MDEV-7974: more to STANDLONE groupping: recovery and io thread retransmit rel.

MDEV-7974: hton ref_count and more tests.

ref_count may be found 1 at shutdown caused by "native" trx detach
which makes THD::ha_data[].ha_ptr zero to hook away the problematic counter decr.
The test part includes rpl_xa_gaps (todo: turn RC on slave whenever ROW format).

MDEV-7974: slave temp failure retry related.

XA state cleanup is completed;
todo: revise/refactor/catch-up-with-upstream/ reattachment mechanism.

MDEV-742 (intermediate commit)

typ == XID_EVENT || typ == XA_PREPARE_LOG_EVENT augmentation.

MDEV-742

A number of cleanup, testing, optimistic fixes and xa prepare logging fixing (still to test out)

MDEV-742

Waiting for prior-to-commit at XA-*prepare*; tested against rpl_optimistic_xa part I; log-bin=ON,OFF tried to OK;

TODO: where is signal-to-following-commit from XA-prepare?

MDEV-742

Fixed thr assignment to XA-terminate parts; proved wakeup consequent commit OK; sketched the 2nd part of rpl_optimistic_xa

MDEV-742

Completed the 2nd part of rpl_optimistic_xa;
added its log-slave-updates=0 version.

Added tc->log,unlog for XA; tested with Binlog checkpoint.

rocksdb xa detaches; pseudo slave tested.

refinement in trans_cant_save_rb; todo added for applier_reset_xa_trans().

binlog checkpoint test is added

manual merge after rebase to compile

hton close connection fixed; tested manually.

More post rebase corrections invoked by rpl_xa_survive_disconnect.

few binlog suite and related tests cosmetic fixes.

server xid corrected

MDEV-742

Removal from execution de-,at-tach_native_trx(); THD_TRANS reset enforce in ha_prepare() to follow commit,rollback patterns.

MDEV-742 - removed already relocated test

MDEV-742 - cleaned off ha_ptr_backup completely.

MDEV-742 - finally removed unused replace_trx_in_thd:s.

MDEV-742 - more cleanup is sql.

Gtid_log_event::xid formatID size fixed.
+std::atomic<int32_t> XID_cache_element_para::cnt

MDEV-742 - Part X: parallel xid hash refinement.

A sequence of xid-namesake XA transactions can be logged on master as
a serious of binlog event groups of

XA_prepare(xid)
XA_compete(xid)
...
XA_compete(xid)
XA_prepare(xid)

where `_complete` stands for COMMIT or ROLLBACK.
Optimistic parallel slave scheduler may assign all of the sequence to
one Worker which ensures no concurrent (optimistic) execution of two
namasake XA:s.

To faciliate that there is a parallel slave local xid hash, one per
replication source. A xid-keyed record is placed there when XA-start
is seen by the Driver thread. Every XA-start will increment the record
usage counter, initially 1. The counter drops by 1 per each
XA-complete by the assigned Worker. The record is evicted when the
counter reaches zero to indicate there are no more XA-start in its
queue for this xid.

A test file is added.

MDEV-742: few test result file update. Interrupted at unlog_xid.

MDEV-742: fixed missed unlog by xa-rollback on unprepared xa.

MDEV-742: cosmetics in 2 tests.

bb-10.5-galera-gtid 2020-01-27 09:39:13 UTC 2020-01-27
Galera GTID support

Author: mkaruza
Author Date: 2019-04-01 11:23:05 UTC

Galera GTID support

Support for galera GTID consistency thru cluster. All nodes in cluster
should have same GTID for replicated events which are originating from cluster.
Cluster originating commands need to contain sequential WSREP GTID seqno
Ignore manual setting of gtid_seq_no=X.

In master-slave scenario where master is non galera node replicated GTID is
replicated and is preserved in all nodes.

To have this - domain_id, server_id and seqnos should be same on all nodes.
Node which bootstraps the cluster, to achieve this, sends domain_id and
server_id to other nodes and this combination is used to write GTID for events
that are replicated inside cluster.

Cluster nodes that are executing non replicated events are going to have different
GTID than replicated ones, difference will be visible in domain part of gtid.

With wsrep_gtid_domain_id you can set domain_id for WSREP cluster.

Functions WSREP_LAST_WRITTEN_GTID, WSREP_LAST_SEEN_GTID and
WSREP_SYNC_WAIT_UPTO_GTID now works with "native" GTID format.

Fixed galera tests to reflect this chances.

Add variable to manually update WSREP GTID seqno in cluster

Add variable to manipulate and change WSREP GTID seqno. Next command
originating from cluster and on same thread will have set seqno and
cluster should change their internal counter to it's value.
Behavior is same as using @@gtid_seq_no for non WSREP transaction.

nm/without-overlaps-rebased 2020-01-27 06:53:14 UTC 2020-01-27
add frm corruption check for extra2.application_period

Author: Nikita Malyavin
Author Date: 2020-01-13 07:53:40 UTC

add frm corruption check for extra2.application_period

bb-10.3-mdev21383 2020-01-24 19:07:22 UTC 2020-01-24
MDEV-21383: Possible range plan is not used under certain conditions

Author: Sergey Petrunia
Author Date: 2020-01-19 21:06:51 UTC

MDEV-21383: Possible range plan is not used under certain conditions

[Variant 2 of the fix: collect the attached conditions]

Problem:
make_join_select() has a section of code which starts with
 "We plan to scan all rows. Check again if we should use an index."

the code in that section will [unnecessarily] re-run the range
optimizer using this condition:

  condition_attached_to_current_table AND current_table's_ON_expr

Note that the original invocation of range optimizer in
make_join_statistics was done using the whole select's WHERE condition.
Taking the whole select's WHERE condition and using multiple-equalities
allowed the range optimizer to infer more range restrictions.

The fix:
- Do range optimization using a condition that is an AND of this table's
condition and all of the previous tables' conditions.
- Also, fix the range optimizer to prefer SEL_ARGs with type=KEY_RANGE
over SEL_ARGS with type=MAYBE_KEY, regardless of the key part.
Computing
key_and(
  SEL_ARG(type=MAYBE_KEY key_part=1),
  SEL_ARG(type=KEY_RANGE, key_part=2)
)
will now produce the SEL_ARG with type=KEY_RANGE.

bb-10.2-MDEV-14183-aria_pack 2020-01-22 18:13:14 UTC 2020-01-22
MDEV-14183: aria_pack segfaults in compress_maria_file

Author: Vlad Lesin
Author Date: 2020-01-22 18:13:14 UTC

MDEV-14183: aria_pack segfaults in compress_maria_file

Post-push fix. aria_pack_mdev14183 test is unstable.

The fix is the following:
1. Disable the test for embedded server.
2. Create non-"transactional" Aria table in the test, as aria_pack does not
support "transactional" Aria tables.

bb-10.4-MDEV-17571 2020-01-22 09:58:50 UTC 2020-01-22
MDEV-17571 : Make systemd timeout behavior more compatible with long Galera SSTs

Author: Jan Lindström
Author Date: 2020-01-22 09:58:50 UTC

MDEV-17571 : Make systemd timeout behavior more compatible with long Galera SSTs

This is 10.4 version.

Idea is to create monitor thread for both donor and joiner that will
periodically if needed extend systemd timeout while SST is being
processed. In 10.4 actual SST is executed by running SST script
and exchanging messages on pipe using blocking fgets. This fix
starts monitoring thread before SST script is started and
we stop monitoring thread when SST has been completed.

nm/period-fk-linear 2020-01-21 13:33:56 UTC 2020-01-21
Period: add versioning combination

Author: Nikita Malyavin
Author Date: 2020-01-21 09:48:47 UTC

Period: add versioning combination

bb-5.5-anel-make-uninstall 2020-01-17 15:23:05 UTC 2020-01-17
Add uninstall target

Author: Anel Husakovic
Author Date: 2020-01-17 15:23:05 UTC

Add uninstall target

bb-10.2-MDEV-17062 2020-01-17 06:50:36 UTC 2020-01-17
MDEV-17062 : Test failure on galera.MW-336

Author: Jan Lindström
Author Date: 2020-01-16 11:18:44 UTC

MDEV-17062 : Test failure on galera.MW-336

Add mutex protection while we calculate required slave
thread change and create them. Add error handling.

bb-5.5-vicentiu 2020-01-16 11:38:50 UTC 2020-01-16
MDEV-21210: main.uniques_crash-7912 tries to allocate 1TB of memory

Author: Vicențiu Ciorbaru
Author Date: 2020-01-16 11:37:21 UTC

MDEV-21210: main.uniques_crash-7912 tries to allocate 1TB of memory

Update uniques_crash-7912 to only cover 5GB of RAM and also work on
unix.

bb-10.2-MDEV-18464 2020-01-16 09:41:54 UTC 2020-01-16
MDEV-18464 : Killing thread can cause mutex deadlock if done concurrently wit...

Author: Jan Lindström
Author Date: 2020-01-15 07:06:32 UTC

MDEV-18464 : Killing thread can cause mutex deadlock if done concurrently with Galera/replication victim kill

Following issues here:

Whenever Galera BF (brute force) transaction decides to abort conflicting transaction it will kill that thread using thd::awake()
Whenever replication selects a thread as a victim it will call thd::awake()
User KILL [QUERY|CONNECTION] ... for a thread it will also call thd::awake()
Whenever one of these actions is executed we will hold number of InnoDB internal mutexes and thd mutexes.
Sometimes these mutexes are taken in different order causing mutex deadlock.

In this patch we will fix Galera BF and user kill cases so that we enqueue
victim thread to a list while we hold InnoDB mutexes and we then release them.
A new background thread will pick victim thread from this new list and uses
thd::awake() with no InnoDB mutexes. Idea is similar to replication background
kill. This fix enforces that we take LOCK_thd_data -> lock sys mutex -> trx mutex
always in this order.

wsrep_mysqld.cc
 Here we introduce a list where victim threads are stored,
 condition variable to be used to wake up background thread
 and mutex to protect list.

wsrep_thd.cc
 Create a new background thread to handle victim thread
 abort. We may take wsrep_thd_LOCK mutex here but not any
 InnoDB mutexes.

wsrep_innobase_kill_one_trx
 Remove all the wsrep code that was moved to wsrep_thd.cc
 We just enqueue required information to background kill
 list and cancel victim trx lock wait if there is such.
 Here we have InnoDB lock sys mutex and trx mutex so here
 we can't take wsrep_thd_LOCK mutex.

wsrep_abort_transaction
 Cleanup only.

10.1-MDEV-19457 2020-01-14 13:23:15 UTC 2020-01-14
MDEV-19457: sys_vars.wsrep_provider_basic failed in buildbot

Author: Julius Goryavsky
Author Date: 2020-01-14 13:23:15 UTC

MDEV-19457: sys_vars.wsrep_provider_basic failed in buildbot

If the initialization of the wsrep provider failed, in some
cases the internal variable wrep_inited indicating that the
initialization has already been completed is still set to
"1", which then leads to confusion in the initialization
status. To solve the problem, we should set this variable
to "1" only if the wsrep provider initialization really
completed successfully.

An earlier issue has already been fixed for branch 10.4,
and this patch contains a fix for earlier versions (where
Galera 3.x is used).

10.1-MDEV-17601 2020-01-14 12:57:14 UTC 2020-01-14
MDEV-17601: MariaDB Galera does not expect 'mbstream' as streamfmt

Author: Julius Goryavsky
Author Date: 2020-01-14 12:57:14 UTC

MDEV-17601: MariaDB Galera does not expect 'mbstream' as streamfmt

Setting "streamfmt=mbstream" in the "[sst]" section causes SST to fail
because the format automatically switches to 'tar' by default (insead
of mbstream).

To fix this, we need to add mbstream to the list of valid values for
the format, making it synonymous with xbstream. This must be done both
in the SST script and when parsing the options of the corresponding
utilities.

bb-10.4-MDEV-19803 2020-01-14 06:05:05 UTC 2020-01-14
Merge branch 'codership-10.4-MDEV-19803' into 10.4

Author: Jan Lindström
Author Date: 2020-01-14 06:05:05 UTC

Merge branch 'codership-10.4-MDEV-19803' into 10.4

bb-10.2-release-kevgs 2020-01-13 19:16:33 UTC 2020-01-13
MDEV-20377 fix build for CRC32

Author: Eugene
Author Date: 2020-01-08 16:59:40 UTC

MDEV-20377 fix build for CRC32

bb-10.4-galera-bug 2020-01-13 13:34:08 UTC 2020-01-13
Merge branch 'codership-10.4-wsrep-position-after-cert-failure' into 10.4

Author: Jan Lindström
Author Date: 2020-01-13 13:34:08 UTC

Merge branch 'codership-10.4-wsrep-position-after-cert-failure' into 10.4

bb-10.3-mdev21341-issueSix 2020-01-12 19:15:55 UTC 2020-01-12
MDEV-21341: Fix UBSAN failures: Issue Six

Author: Sergey Petrunia
Author Date: 2020-01-12 19:15:55 UTC

MDEV-21341: Fix UBSAN failures: Issue Six

(Variant #2 of the patch, which keeps the sp_head object inside the
MEM_ROOT that sp_head object owns)
(10.3 version of the fix, with handling for class sp_package)

sp_head::operator new() and operator delete() were dereferencing sp_head*
pointers to memory that didn't hold a valid sp_head object (it was
not created/already destroyed).
This caused UBSan to crash when looking up type information.

Fixed by providing static sp_head::create() and sp_head::destroy() methods.

bb-10.1-mdev21341-issueSix 2020-01-12 18:50:12 UTC 2020-01-12
MDEV-21341: Fix UBSAN failures: Issue Six

Author: Sergey Petrunia
Author Date: 2020-01-12 18:50:12 UTC

MDEV-21341: Fix UBSAN failures: Issue Six

(Variant #2 of the patch, which keeps the sp_head object inside the
MEM_ROOT that sp_head object owns)
(10.3 requires extra work due to sp_package, will commit a separate
patch for it)

sp_head::operator new() and operator delete() were dereferencing sp_head*
pointers to memory that didn't hold a valid sp_head object (it was
not created/already destroyed).
This caused UBSan to crash when looking up type information.

Fixed by providing static sp_head::create() and sp_head::destroy() methods.

bb-10.3-mdev21243 2020-01-12 12:48:46 UTC 2020-01-12
MDEV-21243: Join buffer: condition is checked in wrong place for range access

Author: Sergey Petrunia
Author Date: 2019-12-07 15:21:36 UTC

MDEV-21243: Join buffer: condition is checked in wrong place for range access

In this scenario:
- There is a possible range access for table T
- And there is a ref access on the same index which uses fewer key parts
- The join optimizer picks the ref access (because it is cheaper)
- make_join_select applies this heuristic to switch to range:
  /* Range uses longer key; Use this instead of ref on key */

Join buffer will be used without having called
JOIN_TAB::make_scan_filter(). This means, conditions that should be
checked when reading table T will be checked after T is joined with the
contents of the join buffer, instead.

Fixed this by adding a make_scan_filter() check.
(updated patch after backport to 10.3)
(Fix testcase on Windows)

bb-10.5-wlad 2020-01-07 18:58:24 UTC 2020-01-07
WIP

Author: Vladislav Vaintroub
Author Date: 2020-01-06 21:17:19 UTC

WIP

bb-10.2-MDEV-13569 2020-01-02 12:23:18 UTC 2020-01-02
MDEV-13569: wsrep_info.plugin failed in buildbot with "no nodes coming from p...

Author: Jan Lindström
Author Date: 2020-01-02 06:06:23 UTC

MDEV-13569: wsrep_info.plugin failed in buildbot with "no nodes coming from prim view

Modify configuration so that all nodes are part of galera cluster
i.e. wsrep_on=ON. Add missing wait conditions.

test changes only.

bb-10.4-MDEV-20793 2019-12-31 06:26:46 UTC 2019-12-31
Merge branch 'codership-10.4-MDEV-20793' into 10.4

Author: Jan Lindström
Author Date: 2019-12-31 06:26:46 UTC

Merge branch 'codership-10.4-MDEV-20793' into 10.4

10.3-vicentiu-json-review 2019-12-27 21:26:25 UTC 2019-12-27
Cleanup and more comments

Author: Vicențiu Ciorbaru
Author Date: 2019-12-27 21:26:25 UTC

Cleanup and more comments

andrei-10.4-XA 2019-12-27 14:04:01 UTC 2019-12-27
server xid corrected

Author: Andrei Elkin
Author Date: 2019-12-27 14:04:01 UTC

server xid corrected

10.5-windows-afunix 2019-12-24 17:22:45 UTC 2019-12-24
Support AF_UNIX socket on Windows

Author: Vladislav Vaintroub
Author Date: 2019-12-24 17:22:45 UTC

Support AF_UNIX socket on Windows

10.5-wlad-tp-fibers 2019-12-24 17:16:51 UTC 2019-12-24
WIP

Author: Vladislav Vaintroub
Author Date: 2019-12-20 11:49:37 UTC

WIP

bb-10.3.10-mdev21243 2019-12-22 22:13:38 UTC 2019-12-22
MDEV-21383: Possible range plan is not used under certain conditions

Author: Sergey Petrunia
Author Date: 2019-12-22 22:13:38 UTC

MDEV-21383: Possible range plan is not used under certain conditions

(10.3's variant of the fix)

make_join_select() has a section of code which starts with
 "We plan to scan all rows. Check again if we should use an index."

the code in that section will [unnecessarily] re-run the range
optimizer using this condition:

  condition_attached_to_current_table AND current_table's_ON_expr

Note that the original invocation of range optimizer in
make_join_statistics was done using the whole select's WHERE condition.

taking the whole select's WHERE condition and using multiple-equalities
allowed the range optimizer to do more inferences.

This fix uses a very conservative approach: we still re-run the range
optimizer, but we save the quick select we already have, and take the
best of the two quick selects.

bb-10.1-mdev21341 2019-12-18 18:53:19 UTC 2019-12-18
MDEV-21341: Fix UBSAN failures, part 8: fix error in compare_fields_by_table_...

Author: Sergey Petrunia
Author Date: 2019-12-18 18:53:19 UTC

MDEV-21341: Fix UBSAN failures, part 8: fix error in compare_fields_by_table_order

Dont assign Item_field variables to point to Item_string objects (even if we
don't make any dangerous calls for them).

bb-10.4-vicentiu 2019-12-18 10:26:58 UTC 2019-12-18
Merge branch '10.3' into 10.4

Author: Vicențiu Ciorbaru
Author Date: 2019-12-18 10:26:58 UTC

Merge branch '10.3' into 10.4

bb-10.4-MDEV-21335 2019-12-18 06:22:07 UTC 2019-12-18
MDEV-21335 : Galera test failure on suite wsrep

Author: Jan Lindström
Author Date: 2019-12-18 06:22:07 UTC

MDEV-21335 : Galera test failure on suite wsrep

Problem was that wsrep_on was OFF.

This is 10.4 version.

bb-10.2-MDEV-21335 2019-12-17 10:10:36 UTC 2019-12-17
MDEV-21335 : Galera test failure on suite wsrep

Author: Jan Lindström
Author Date: 2019-12-17 10:10:36 UTC

MDEV-21335 : Galera test failure on suite wsrep

Problem was that wsrep_on was OFF.

bb-10.4-spider-ks 2019-12-05 19:56:57 UTC 2019-12-05
fix compiler warnings

Author: Kentoku SHIBA
Author Date: 2019-12-05 19:32:56 UTC

fix compiler warnings

bb-10.3-anel-MDEV-18323 2019-12-05 12:23:36 UTC 2019-12-05
After review fix

Author: Anel Husakovic
Author Date: 2019-12-05 12:23:32 UTC

After review fix

- Delete byte at the end of key/values
- Add space after colon for keys and comma for values
- Escaping character `'` should be ignored

10.3-vicentiu 2019-12-04 21:37:04 UTC 2019-12-04
cleanup

Author: Vicențiu Ciorbaru
Author Date: 2019-12-04 21:37:04 UTC

cleanup

bb-10.5-mdev-17088 2019-12-04 12:01:57 UTC 2019-12-04
A cleanup for MDEV-17088 Provide tools to encode/decode mysql-encoded file sy...

Author: Alexander Barkov
Author Date: 2019-12-04 11:49:31 UTC

A cleanup for MDEV-17088 Provide tools to encode/decode mysql-encoded file system names

- Load and convert the entire input file at once,
  rather than reading string-by-string using fgets().
  This change makes it possible to convert from UCS2, UTF16, UTF32 data.
- Adding the --delimiter command, to treat the specified
  characters as delimiters rather than data to convert.
  Useful in combination with `-f filename` or `-t filename`.
  The delimiter characters are not converted,
  they are copied from the input to the output as is.

bb-10.4-MDEV-20848 2019-12-03 13:02:17 UTC 2019-12-03
Merge branch 'codership-10.4-MDEV-20848' into 10.4

Author: Jan Lindström
Author Date: 2019-12-03 13:02:17 UTC

Merge branch 'codership-10.4-MDEV-20848' into 10.4

bb-10.5-mdev-12518 2019-12-03 08:57:09 UTC 2019-12-03
Part2: MDEV-12518 Unify sql_yacc.yy and sql_yacc_ora.yy

Author: Vladislav Vaintroub
Author Date: 2019-11-26 08:35:09 UTC

Part2: MDEV-12518 Unify sql_yacc.yy and sql_yacc_ora.yy

Generate sql_yacc_ora.yy from sql_yacc.yy , by using cmake script
which does some simple string(REPLACE)

bb-10.4-MDEV-18973_2 2019-11-29 14:23:57 UTC 2019-11-29
MDEV-18973 CLIENT_FOUND_ROWS wrong in spider

Author: Kentoku SHIBA
Author Date: 2019-11-28 23:22:13 UTC

MDEV-18973 CLIENT_FOUND_ROWS wrong in spider

Get count from last_used_con->info
Contributed by willhan at Tencent Games

10.5-circular-buffer 2019-11-28 18:09:22 UTC 2019-11-28
more info

Author: Sachin Setiya
Author Date: 2019-11-28 18:09:22 UTC

more info

bb-10.3.11-xtrabackup_copy_logfile_failed-MDEV-18611 2019-11-28 13:32:08 UTC 2019-11-28
Add some extra logging to catch the case when page is written with wrong offset.

Author: Vlad Lesin
Author Date: 2019-11-27 22:16:22 UTC

Add some extra logging to catch the case when page is written with wrong offset.

bb-10.3.17-MDEV-21109-wrong-page-no 2019-11-28 13:32:08 UTC 2019-11-28
Add some extra logging to catch the case when page is written with wrong offset.

Author: Vlad Lesin
Author Date: 2019-11-27 22:16:22 UTC

Add some extra logging to catch the case when page is written with wrong offset.

bb-10.3-MDEV-21109-wrong-page-no 2019-11-27 22:16:22 UTC 2019-11-27
Add some extra logging to catch the case when page is written with wrong offset.

Author: Vlad Lesin
Author Date: 2019-11-27 22:16:22 UTC

Add some extra logging to catch the case when page is written with wrong offset.

bb-10.3-wlad 2019-11-27 19:44:14 UTC 2019-11-27
MDEV-19669 proxy_protocol_networks does not evaluate/parse properly

Author: Vladislav Vaintroub
Author Date: 2019-11-27 19:44:14 UTC

MDEV-19669
proxy_protocol_networks does not evaluate/parse properly

Prior to this fix, when matching addresses using mask,
extra bits could be used for comparison, e.g to
match with "a.b.c.d/24" , 27 bits were compared rather than 24.

The patch fixes the calculation.

bb-10.4-MDEV-19781 2019-11-26 15:17:54 UTC 2019-11-26
MDEV-19781 Create MariaDB named commands on Windows

Author: Rasmus Johansson
Author Date: 2019-11-17 08:39:47 UTC

MDEV-19781 Create MariaDB named commands on Windows

Added CreateSymlinks and DeleteSymlinks functions to
CustomAction.cpp. Extra.wxs.in calls them.

nm/replace 2019-11-26 14:38:34 UTC 2019-11-26
move gotos to funcs

Author: Nikita Malyavin
Author Date: 2019-10-31 23:38:22 UTC

move gotos to funcs

nm/period-fk-fallback 2019-11-26 14:38:33 UTC 2019-11-26
check referenced table period name in FK

Author: Nikita Malyavin
Author Date: 2019-08-16 12:12:05 UTC

check referenced table period name in FK

bb-10.1-galera 2019-11-25 12:46:48 UTC 2019-11-25
Merge branch 'codership-bb-10.1-MDEV-19572' into 10.1

Author: Jan Lindström
Author Date: 2019-11-25 12:46:48 UTC

Merge branch 'codership-bb-10.1-MDEV-19572' into 10.1

bb-10.5-MDEV-16039-nikita 2019-11-20 03:25:17 UTC 2019-11-20
MDEV-16039 Crash when selecting virtual columns generated using functions wit...

Author: Nikita Malyavin
Author Date: 2019-09-03 18:29:03 UTC

MDEV-16039 Crash when selecting virtual columns generated using functions with DAYNAME()

Due to collation specifics an Item tree could change while fixing. Virtual fields.

This should be done on the correct query arena, which is table->expr_arena.

bb-10.2-anel-MDEV-20787 2019-11-19 14:00:48 UTC 2019-11-19
MDEV-20787: Script dgcov.pl does not work

Author: Anel Husakovic
Author Date: 2019-11-18 18:01:20 UTC

MDEV-20787: Script dgcov.pl does not work

Let's change CMakeList with `--coverage` flag as an alias for
`-fprofile-arcs -ftest-coverage -lgcov` in addition.
When the server is compiled with `-DENABLE_GCOV=ON`, from object files are generated
`.gcno` and `.gcda` files.
`./mtr --gcov is_check_constraint` is invoking the script calls
`./dgcov.pl --purge`, `./mtr is_check_constraint`,
`./dgcov.pl --generate>/var/last_changes.dgcov`.
The `purge` flag is clearing `.gcda` files (and others extensions),
while running the test new `.gcda` files are obtained.
With `generate` flag, `gcov -i` (`intermediate format`) is called
on obtained `<object-files-name>.gcda` files (`dbug.c.gcda` e.g.).
The patch is tested on `gcov 6.3` and `gcov 7.4` versions
and can be seen that resulting `.gcov` file for `6.3` creates
`<full path>.gcov` (`dbug.c.gcda.gcov` e.g.) file,
where `gcov 7.4` is still creating `object-file-names.gcov`(`dbug.c.gcov`) files
as `gcov` in general is doing.

bb-10.5-sachin 2019-11-18 17:21:58 UTC 2019-11-18
MDEV-21063 Very many test failures on big-endian PowerPC

Author: Sachin Setiya
Author Date: 2019-11-18 14:35:28 UTC

MDEV-21063 Very many test failures on big-endian PowerPC

Memcpy is endian dependent, So instead of memcpy we will use int2store.
And m_metadata_size can be 0,1 or 2, And int2store will take care of it.

bb-10.2-MDEV-21050-isnan-isinf-isfinite-ported 2019-11-18 12:30:13 UTC 2019-11-18
Use std::isfinite in C++ code

Author: Sergey Vojtovich
Author Date: 2018-05-23 14:52:55 UTC

Use std::isfinite in C++ code

This is addition to parent revision fixing build failures.

(cherry picked from commit 54999f4e75f42baca484ae436b382ca8817df1dd)

bb-10.3-mdev20611 2019-11-16 10:18:24 UTC 2019-11-16
Fix compile failure on Windows: use explicit type casts

Author: Sergey Petrunia
Author Date: 2019-11-16 10:18:24 UTC

Fix compile failure on Windows: use explicit type casts

bb-10.5-robert 2019-11-15 11:23:42 UTC 2019-11-15
Don't use plugin->data for storage engine plugins

Author: Sergey Vojtovich
Author Date: 2019-11-14 13:45:19 UTC

Don't use plugin->data for storage engine plugins

Use plugin->plugin->info->hton instead.
plugin_data() replaced with plugin_hton().
plugin_hton() must never return NULL anymore and is only good to be called
against plugins in PLUGIN_IS_READY state.

Part of
MDEV-20044 - Replace dynamic storage engine initialisation with declarative
             approach

bb-10.4-wlad 2019-11-15 11:01:05 UTC 2019-11-15
MDEV-21062 Buildbot, Windows - sporadically missing lines from mtr's "exec"

Author: Vladislav Vaintroub
Author Date: 2019-11-13 20:12:48 UTC

MDEV-21062 Buildbot, Windows - sporadically missing lines from mtr's "exec"

Provide own version of popen/pclose, in attempt to workaround
sporadic erratic behavior of UCRT's one.

bb-10.5-mdev20854 2019-11-12 11:38:31 UTC 2019-11-12
MDEV-20854: ANALYZE for statements: not clear where the time is spent

Author: Sergey Petrunia
Author Date: 2019-11-09 18:03:23 UTC

MDEV-20854: ANALYZE for statements: not clear where the time is spent

Count the "gap" time between table accesses and display it as
r_other_time_ms in the "table" element.

* The advantage of this approach is that it doesn't add any new
  my_timer_cycles() calls.
* The disadvantage is that the definition of what is done during
  "other time" is not that clear: it includes checking the WHERE
  (for this table), constructing index lookup tuple (for the next table)
  writing to GROUP BY temporary table (as we dont account for that time
  separately [yet], etc)

bb-10.4-MDEV-18973 2019-11-08 20:57:16 UTC 2019-11-08
MDEV-18973 CLIENT_FOUND_ROWS wrong in spider

Author: Kentoku SHIBA
Author Date: 2019-11-08 01:27:07 UTC

MDEV-18973 CLIENT_FOUND_ROWS wrong in spider

Get count from last_used_con->info
Contributed by willhan at Tencent Games

bb-10.3-hf 2019-10-31 22:33:25 UTC 2019-10-31
MDEV-18244

Author: Alexey Botchkov
Author Date: 2019-10-31 22:33:25 UTC

MDEV-18244

bb-10.1-robert 2019-10-31 10:42:14 UTC 2019-10-31
MDEV-17896 Assertion `pfs->get_refcount() > 0' failed

Author: Robert Bindar
Author Date: 2019-10-10 09:58:29 UTC

MDEV-17896 Assertion `pfs->get_refcount() > 0' failed

Unfortunate DROP TEMPORARY..IF EXISTS on a regular table may allow
subsequent CREATE TABLE statements to steal away the PFS_table_share
instance from the dropped table.

bb-5.5-release 2019-10-29 23:47:50 UTC 2019-10-29
compilation fix for Windows

Author: Sergei Golubchik
Author Date: 2019-10-29 23:47:50 UTC

compilation fix for Windows

bb-5.5-kevgs 2019-10-29 18:56:24 UTC 2019-10-29
add .clang-format file for InnoDB

Author: Eugene
Author Date: 2019-10-29 18:56:24 UTC

add .clang-format file for InnoDB

201300 of 618 results

Other repositories

Name Last Modified
lp:maria 4 hours ago
lp:~maria-captains/maria/+git/connector-c 2018-01-08
12 of 2 results
You can't create new repositories for MariaDB.