Comment 9 for bug 1387380

Revision history for this message
Gavin Panella (allenap) wrote :

A fix is up for review. There are unit tests that cover older lshw formats as well as these new ones but that's not really what I'm worried about.

We always use the same release for commissioning (in trunk and 1.7 that means 14.04) so I'd expect to see a consistent lshw XML structure for all nodes. The format has certainly evolved from previous releases, but it ought to be consistent within a single release.

However, what I don't know is how the XML varies for different hardware, and if this new XPath expression is going to DTRT in all cases.

It would be useful to collect lshw dumps for lots of different hardware, recorded along with the Ubuntu release and lshw version it was obtained from. We could then check our code against these as part of the landing process.