Comment 6 for bug 384916

Revision history for this message
Severin H (severinh) wrote :

I just gave your patch a try and it works perfectly using Firefox 3.0! I'll still need to test Firefox 3.5 on my Ubuntu 9.10 Alpha 5 machine. One just needs to make sure that "update-desktop-database -q" is run after the installation of the package. For some odd reason, this isn't the case if build the package on my own system. The command is executed though if the package is built by Launchpad (using the PPA infrastructure).

Again. Thanks alot for your hard work. You're going to make many LottaNZB users happy. :-)

It's possible to apply the new patch with a simple command. You did everything right. If you'd like me to, I won't commit the patch right away, but guide you through the process of pushing your own branch to Launchpad and making a merge proposal, only if you're interested of course.

1. You've already branched the code and changed it to create the new patch.
2. Commit your change to your local branch: bzr commit -m "Fix MIME type issue for Newzbin downloads. Fixes #384916."
3. bzr whoami "Marcel de Vries"
4. If you don't have an SSH key yet:
4.1. sudo apt-get install openssh-client
4.2. ssh-keygen -t rsa (use the defaults and choose a secure password)
4.3. Your key pair is stored in ~/.ssh/ as id_rsa.pub (public key) and id_rsa (private key)
5. Visit https://launchpad.net/people/+me/+editsshkeys and paste your public key (id_rsa.pub) into the text box.
6. bzr launchpad-login marceldevries
7. bzr push lp:~marceldevries/lottanzb/bug_384916 --remember

Let's hope I didn't forget anything. You branch should show up soon at https://code.launchpad.net/lottanzb and you can propose a merge into lp:lottanzb/0.5.

Of course, steps 3 to 6 only need to be done once. You can commit other changes using "bzr commit ..." and push them using "bzr push".

This process might look a little tiresome, but once you get used to it, it's amazingly powerful and a great way of collaborating. Patch files can get lost or be forgotten, but using a branch, the only difference between your workflow and the one by the core developers of the project is that you don't have write access to the main branch.