In discussing cancelling builds, two things came up today on IRC:
1) We need a new build status ("cancelled"?) in the DB to represent cancelled builds so that they don't get retried again and again. This current interface should twiddle that column when used.
2) We can easily hard-cancel builds on virtual builders (currently, only PPA) by just resetting the Xen guest completely, rather than having logic in launchpad-buildd to attempt to kill the build. This is bound to be more reliable anyway, so may as well be implemented.
In discussing cancelling builds, two things came up today on IRC:
1) We need a new build status ("cancelled"?) in the DB to represent cancelled builds so that they don't get retried again and again. This current interface should twiddle that column when used.
2) We can easily hard-cancel builds on virtual builders (currently, only PPA) by just resetting the Xen guest completely, rather than having logic in launchpad-buildd to attempt to kill the build. This is bound to be more reliable anyway, so may as well be implemented.
if ((current_builder == virtual) && (action = cancel)) { mark_build_ cancelled( ); ppa_reset }