Comment 1 for bug 462543

Revision history for this message
Thomas Herve (therve) wrote :

[1]
+ifneq (,$(findstring $(dist_release),"hardy"))
+ # We want update-motd in intrepid and jaunty

This comment, and the following, look wrong.

[2]
+class ReleaseUpgraderConfiguration(PackageTaskHandlerConfiguration):
+ """Specialized configuration for the Landscape package-reporter."""

It seems to be the release upgrade configuration.

[3]
+ if os.getuid() == 0:
+ os.setgid(grp.getgrnam("landscape").gr_gid)
+ os.setuid(pwd.getpwnam("landscape").pw_uid)
+
+ reporter = find_reporter_command()
+
+ # Force a smart-update run, because the sources.list has changed
+ args = ["--force-smart-update"]
+
+ if self._config.config is not None:
+ args.append("--config=%s" % self._config.config)
+

As discussed, this code should be shared with the changer, possibly switching to use the uid/gid arguments to reactor.spawnProcess.

I didn't test the branch functionally, but it looked good. +1!