Comment 1 for bug 615157

Revision history for this message
D'Arcy Cain (darcy-6) wrote :

I have a patch for this. The attached patch mostly copies the code from the MySQL driver with changes for PG. There are also a few other minor changes.

 - Removed some extraneous, trailing whitespace.
 - Added some missing "static" keywords.
 - Removed quotes from queries.

The last is probably a separate issue. Let me know if you need the patch split. To explain, the existing code wraps the PG entities in quotes. Sounds like a good idea but it breaks some code. In my case, for example, I need this query:

  SELECT * from vex.jabberauth WHERE username =...

The "vex" part is a PostgreSQL schema. Putting quotes around the table turns it into a table called "vex.jabberauth" in the public (default) schema instead of table "jabberauth" in the "vex" schema. I think that if the caller needs quotes there they should add them in c2s.xml.