Comment 23 for bug 1882671

Revision history for this message
Laszlo Ersek (Red Hat) (lersek) wrote :

Christian,

> But it seems for legacy roms like 82540em.rom CONFIG=qemu being set or not doesn't make a
> difference.

(1) That's my understanding as well; from the following original iPXE commits anyway:

- a15c0d7e868a ("[efi] Allow user experience to be downgraded", 2015-07-22),
- a200ad462e69 ("[build] Add named configuration for qemu", 2015-07-22).

(I played a part in those commits existing.)

(2) However, just to be 100% sure, I recommend *not* changing the CONFIG=<whatever> setting for the traditional BIOS build. If you have had CONFIG=qemu there, then keep it. If you haven't, then don't add it now.

What matters is that the EFI build be performed with CONFIG=qemu.

(FWIW, last time I looked, in RHEL downstream we used to build iPXE with CONFIG=qemu covering *both* the traditional BIOS image and the EFI image. But, I don't think that's enough reason for you to diverge now from your previous BIOS image settings in Ubuntu. I don't think you should risk regressions with that. Really, what matters is that the EFI image be built with CONFIG=qemu.)

Thanks
Laszlo