Comment 4 for bug 1419823

Revision history for this message
Kamil Rykowski (kamil-rykowski) wrote :

Agree with you Brian. When I was thinking about this one it wasn't clear for me why anyone would like to store a null as the value for the image property. Even the idea is incomprehensible I didn't want to push changes which will break backward compatibility (Horizon sets description to null as I've mentioned in bug description).

I've prepared some straightforward patches which won't break anything, but well ... I'm not totally comfortable with it and I'm open to change the direction to fix it. Here are three approaches we can go through:

- add the DEFAULT value at the database level (image_property table) to empty string
- raising exception at the Glance API when someone tries to set property to null (will probably need to make some conversion at the client level null->"")
- changing value of the property to empty string when someone tries to set it to null at the Glance API level

Any thoughts?