Comment 16 for bug 1479316

Revision history for this message
mdavidsaver (mdavidsaver) wrote :

The three you applied all seem to me straight forward fixes without much chance of side-effects.

With repeaterSubscribeTimer.patch I'm a little concerned about adding a lock to repeaterSubscribeTimer::expire as there are other locks and callbacks involved. I couldn't find anything which deadlocks, but I don't claim to understand this code all that well.

With osiLocalAddr.patch I made some changes to the WIN32 implementation which I don't think are adaquately tested.

IMO more eyes are needed before applying these to stable branches.