Comment 13 for bug 1698337

Reviewed: https://review.opendev.org/728824
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=4a424ecabbb14e230be45864ee7eeca3722d49e8
Submitter: Zuul
Branch: master

commit 4a424ecabbb14e230be45864ee7eeca3722d49e8
Author: Simon Westphahl <email address hidden>
Date: Wed May 13 07:56:16 2020 +0200

    Use kpartx option to update partition mappings

    Fix cases of 'mkfs' failing because the partitions never showed up. Partition
    mappings will now be updated instead of just adding them with 'kpartx'. That
    means that 'kpartx' will also remove devmappings for deleted partitions.

    Traceback of failing mkfs call:

    2020-05-11 22:03:25.523 | INFO diskimage_builder.block_device.utils [-] Calling [sudo sync]
    2020-05-11 22:03:25.539 | INFO diskimage_builder.block_device.utils [-] Calling [sudo kpartx -avs /dev/loop0]
    2020-05-11 22:03:25.581 | INFO diskimage_builder.block_device.utils [-] Calling [sudo mkfs -t ext4 -i 4096 -J size=64 -L cloudimg-rootfs -U 21c6f9eb-4d52-4e5c-b9b7-796735de8909 -q /dev/mapper/loop0p1]
    2020-05-11 22:03:25.700 | ERROR diskimage_builder.block_device.blockdevice [-] Create failed; rollback initiated
    2020-05-11 22:03:25.700 | Traceback (most recent call last):
    2020-05-11 22:03:25.700 | File "/home/zuul/dib/lib/python3.6/site-packages/diskimage_builder/block_device/blockdevice.py", line 406, in cmd_create
    2020-05-11 22:03:25.700 | node.create()
    2020-05-11 22:03:25.700 | File "/home/zuul/dib/lib/python3.6/site-packages/diskimage_builder/block_device/level2/mkfs.py", line 133, in create
    2020-05-11 22:03:25.700 | exec_sudo(cmd)
    2020-05-11 22:03:25.700 | File "/home/zuul/dib/lib/python3.6/site-packages/diskimage_builder/block_device/utils.py", line 143, in exec_sudo
    2020-05-11 22:03:25.700 | raise e
    2020-05-11 22:03:25.700 | diskimage_builder.block_device.exception.BlockDeviceSetupException: exec_sudo failed
    2020-05-11 22:03:25.700 | INFO diskimage_builder.block_device.level0.localloop [-] loopdev detach
    2020-05-11 22:03:25.701 | INFO diskimage_builder.block_device.utils [-] Calling [sudo losetup -d /dev/loop0]
    2020-05-11 22:03:25.732 | INFO diskimage_builder.block_device.level0.localloop [-] Remove image file [/tmp/dib_image.muyw7t1h/image0.raw]
    2020-05-11 22:03:25.734 | ERROR diskimage_builder.block_device.blockdevice [-] Rollback complete, exiting
    2020-05-11 22:03:25.740 | Traceback (most recent call last):
    2020-05-11 22:03:25.740 | File "/home/zuul/dib/bin/dib-block-device", line 8, in <module>
    2020-05-11 22:03:25.740 | sys.exit(main())
    2020-05-11 22:03:25.740 | File "/home/zuul/dib/lib/python3.6/site-packages/diskimage_builder/block_device/cmd.py", line 120, in main
    2020-05-11 22:03:25.740 | return bdc.main()
    2020-05-11 22:03:25.740 | File "/home/zuul/dib/lib/python3.6/site-packages/diskimage_builder/block_device/cmd.py", line 115, in main
    2020-05-11 22:03:25.740 | self.args.func()
    2020-05-11 22:03:25.740 | File "/home/zuul/dib/lib/python3.6/site-packages/diskimage_builder/block_device/cmd.py", line 36, in cmd_create
    2020-05-11 22:03:25.740 | self.bd.cmd_create()
    2020-05-11 22:03:25.740 | File "/home/zuul/dib/lib/python3.6/site-packages/diskimage_builder/block_device/blockdevice.py", line 406, in cmd_create
    2020-05-11 22:03:25.740 | node.create()
    2020-05-11 22:03:25.740 | File "/home/zuul/dib/lib/python3.6/site-packages/diskimage_builder/block_device/level2/mkfs.py", line 133, in create
    2020-05-11 22:03:25.740 | exec_sudo(cmd)
    2020-05-11 22:03:25.740 | File "/home/zuul/dib/lib/python3.6/site-packages/diskimage_builder/block_device/utils.py", line 143, in exec_sudo
    2020-05-11 22:03:25.740 | raise e
    2020-05-11 22:03:25.740 | diskimage_builder.block_device.exception.BlockDeviceSetupException: exec_sudo failed

    Change-Id: I374f7f22f9e93ef35eb5813712ca59e75f0733e8
    Related-Bug: #1698337