Thank you for taking out your valuable time to review my charm. As per you suggestions I have revised my charm to fix those issues.
Issues fixed:
- Included the juju expose charm in readme.
- Used `open-port` to open the 9990 port.
- made the admin user and password configurable via config.yaml
- start hook is idempotent now.
Existing issue:
- verify the file contents cryptographically before installing;
The reason behind this issue is that there is no cryptographic key provided with the wildfly download. I have raised this issue with wildfly people. Hope they fix it soon.
Hi Matt,
Thank you for taking out your valuable time to review my charm. As per you suggestions I have revised my charm to fix those issues.
Issues fixed:
- Included the juju expose charm in readme.
- Used `open-port` to open the 9990 port.
- made the admin user and password configurable via config.yaml
- start hook is idempotent now.
Existing issue:
- verify the file contents cryptographically before installing;
The reason behind this issue is that there is no cryptographic key provided with the wildfly download. I have raised this issue with wildfly people. Hope they fix it soon.