Bugs:
*'curl' needs to be added as an apt-get install dependency if you use the charm under LXC.
*If you use the 'user', 'password' config options then these can be obtained simply by accessing the URL - https://xxx/juju-ui/assets/config.js .
Comments:
*metadata.yaml, for consistency I'd move the maintainer line to below 'summary'.
*I'd mention in the README that you may need to add a https certificate exception for self-signed certificates for port 8080 ('juju-api-port'). I found I couldn't get the UI to appear unless I first accessed on port 8080 and accepted the self-signed certificate.
*I'd anonymise the EC2 address in the README. You never know, this charm might generate accidental traffic for a real site :)
Please fix the bugs and consider the comments, then reopen for a second review.
Thanks for your submission. A very nice charm :)
I've tested on EC2 and LXC.
Please see bugs/comments below.
Bugs:
*'curl' needs to be added as an apt-get install dependency if you use the charm under LXC.
*If you use the 'user', 'password' config options then these can be obtained simply by accessing the URL - https:/ /xxx/juju- ui/assets/ config. js .
Comments:
*metadata.yaml, for consistency I'd move the maintainer line to below 'summary'.
*I'd mention in the README that you may need to add a https certificate exception for self-signed certificates for port 8080 ('juju-api-port'). I found I couldn't get the UI to appear unless I first accessed on port 8080 and accepted the self-signed certificate.
*I'd anonymise the EC2 address in the README. You never know, this charm might generate accidental traffic for a real site :)
Please fix the bugs and consider the comments, then reopen for a second review.