Comment 1 for bug 433779

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Oscar Fuentes wrote:
> Public bug reported:
>
> Committing from Emacs on Windows XP produced a traceback complaining
> about the log message. The problem was the same either with utf-8 and
> windows-1252 encodings for the the log message.
>
> Committing to: D:/dev/idb-llvm/lp0/
> modified var.h
> modified var.cpp
> modified backend.cpp
> modified llvm.cpp
> aborting commit write group: ValueError("Invalid value for commit message: u'llvm-cmds branch: Nueva variable\\r\\n`defstaticDestructorDestroyer`. Necesaria porque la expresi\\xf3n\\r\\n`Commands::DataDestroyer<DefstaticDestructor>` se resolv\\xeda a una\\r\\naddress diferente en el plugin LLVM cuando se compilaba en mingw,\\r\\nproduciendo crashes en test cases que invocaban destructores de\\r\\ndefstatics.\\r\\n'",)
> bzr: ERROR: exceptions.ValueError: Invalid value for commit message: u'llvm-cmds branch: Nueva variable\r\n`defstaticDestructorDestroyer`. Necesaria porque la expresi\xf3n\r\n`Commands::DataDestroyer<DefstaticDestructor>` se resolv\xeda a una\r\naddress diferente en el plugin LLVM cuando se compilaba en mingw,\r\nproduciendo crashes en test cases que invocaban destructores de\r\ndefstatics.\r\n'
>
> Traceback (most recent call last):
> File "bzrlib\commands.pyo", line 842, in exception_to_return_code
> File "bzrlib\commands.pyo", line 1037, in run_bzr
> File "bzrlib\commands.pyo", line 654, in run_argv_aliases
> File "bzrlib\builtins.pyo", line 3051, in run
> File "bzrlib\decorators.pyo", line 192, in write_locked
> File "bzrlib\workingtree_4.pyo", line 197, in commit
> File "bzrlib\decorators.pyo", line 192, in write_locked
> File "bzrlib\mutabletree.pyo", line 228, in commit
> File "bzrlib\commit.pyo", line 375, in commit
> File "bzrlib\repository.pyo", line 163, in commit
> File "bzrlib\repository.pyo", line 146, in _validate_unicode_text
> ValueError: Invalid value for commit message: u'llvm-cmds branch: Nueva variable\r\n`defstaticDestructorDestroyer`. Necesaria porque la expresi\xf3n\r\n`Commands::DataDestroyer<DefstaticDestructor>` se resolv\xeda a una\r\naddress diferente en el plugin LLVM cuando se compilaba en mingw,\r\nproduciendo crashes en test cases que invocaban destructores de\r\ndefstatics.\r\n'
>

^- My guess is that the '\r\n' is being caught and rejected. We prefer
to have regular "\n" line endings. I'm not sure what code is passing
these in that isn't sanitizing them. Are you using a special emacs plugin?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkq3BM8ACgkQJdeBCYSNAAPRfACghUWCj4TVd99OqPYwLYBtk6g4
/xcAn2YsE/2JT1gwzHug7tALbtGS26UD
=LMjG
-----END PGP SIGNATURE-----