Comment 1 for bug 1046284

Revision history for this message
John A Meinel (jameinel) wrote :

It looks like this is a bug since bzr-2.5, so we need to fix it.
The issue is that the get_file_text code is calling list(iterator_of_iterator) but that iterator is returning a nested generator, and you are meant to consume that generator before you step the outer iterator.

Anyway, the fix is pretty straightforward, so I'll put together an updated 2.5 branch.
The only reason we saw this is because prior to 2.5 RemoteRepository didn't have an RPC implementation if iter_files_bytes, so we didn't see the lack of consuming the inner iterator.