Comment 2 for bug 963742

Revision history for this message
Richard Wilbur (richard-wilbur) wrote :

I patched the code as Роман Донченко described, merged, and reloaded to see that the home page didn't change.

Next, I tried running
bzr-website$ python build.py
fetching data from http://feeds.launchpad.net/bazaar/announcements.atom
Traceback (most recent call last):
  File "build.py", line 121, in <module>
    main()
  File "build.py", line 107, in main
    build_feed("Community News", NEWS_RSS, 4),
  File "build.py", line 63, in build_feed
    d = feedparser.parse(rss_url, extra_headers={'Cache-control': 'max-age=60'})
TypeError: parse() got an unexpected keyword argument 'extra_headers'

So, next I took a look at feedparser.parse() and I can't find a version which provides the keyword argument 'extra_headers'. I did find that v>=5.1.3 all provide 'request_headers' and 'response_headers', so I modified build.py to try 'request_headers' or leave out the extra parameter. This works properly on my machine and regenerates index.html as expected.

In light of the local success, I committed, pushed branch to lp, recorded the reasons for this on the merge proposal, approved it, and merged it. So far, I have yet to see any changes on the homepage.

Does anyone know what triggers the rebuild of index.html on lp:bzr-website?
Does lp:bzr-website require a private patched copy of feedparser in order to work? I guess I found my answer on lp:716446 for this question.