Mixxx

no change of searchbox contend when changing library feature

Bug #998836 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Daniel Schürmann
1.10
Fix Released
Low
Daniel Schürmann
Mixxx 1.10.1

Bug Description

The serachbox does not display the current search (filter) when moving through the library tree in any case.

Daniel Schürmann (daschuer)
Changed in mixxx:
status: New → In Progress
assignee: nobody → Daniel Schürmann (daschuer)
Revision history for this message
Daniel Schürmann (daschuer) wrote :

the attached patch solves the problem for lp:mixxx #3154.
Bug #995957 is also solved by this patch.

Revision history for this message
jus (jus) wrote :

We had a discussion about that some month back, we could take the chance and decide now what is the preferred behavior https://bugs.launchpad.net/mixxx/+bug/689291

Revision history for this message
Daniel Schürmann (daschuer) wrote :

This bug is an issues only for the current behavior.
This is, that every feature saves its current search.

Without the patch, the searchbox is not properly refreshed when moving through the library. This is annoying because sometimes simply a wrong filter is displayed.

I would prefer to commit this patch and to postpone the general thing until we renovating the library view.

I will add my additional comments to Bug #689291.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

There seem to be a few stray tab characters in the patch but otherwise looks good to me (and since it fixes current intended behavior it can go in independent of the discussion in Bug #689291)

Changed in mixxx:
milestone: none → 1.11.0
importance: Undecided → Low
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Committed lp:mixxx #3247

Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
jus (jus) wrote :

Hi Daniel, just FYI.
It looks like your latest fixes to trunk were committed without the " --fixes lp:XXXXX" option. Because of this the fixed bugs are not automatically linked to the respective branch ( e.g. lp:mixxx ) and are not searchable by bug# with bazaars log function (see screenshot).
http://doc.bazaar.canonical.com/beta/en/tutorials/using_bazaar_with_launchpad.html#changing-the-state-in-launchpad-while-committing-in-bazaar

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Hi jus, thank you for the hint!

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Merged to lp:mixxx/1.10 #3107

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
milestone: 1.11.0 → none
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6435

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.