pt-table-sync sets binlog_format needlessly
Bug #997155 reported by
Burak Gürsoy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Baron Schwartz |
Bug Description
Hi,
We have a RBR setup and also limited permissons for the related MySQL user.
So, this command
SET @@binlog_
is causing problems in our systems. I think it needs to be controlled with an
option to be able to override. I'm attaching a patch for this. The search
functionality in this bug tracker is giving me not found errors. Sorry if
there is an already existing related bug.
Thanks,
Burak
Relevant additional info:
I'm using pt-table-sync 2.1.1
Related branches
lp:~percona-toolkit-dev/percona-toolkit/pt-table-sync-binlog-format-only-if-not-statement
- Daniel Nichter: Approve
-
Diff: 42 lines (+29/-3)1 file modifiedbin/pt-table-sync (+29/-3)
Changed in percona-toolkit: | |
status: | New → Triaged |
tags: | added: privs pt-table-sync rbr |
summary: |
- Make the binlog_format setting in pt-table-sync optional + pt-table-sync sets binlog_format needlessly |
tags: | added: useless-work |
Changed in percona-toolkit: | |
status: | Confirmed → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
pt-table-sync absolutely requires binlog_ format= STATEMENT for making changes in a safe way. However we can do the same thing we did for pt-table-checksum, which is set the format only if it isn't already STATEMENT.