[SRU] Memory is not correctly computed for Xen+libvirt

Bug #997014 reported by Alvaro Lopez
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Alvaro Lopez
Essex
Fix Released
Undecided
Unassigned
nova (CentOS)
New
Undecided
Unassigned
nova (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Chuck Short

Bug Description

The current code in libvirt/connection.py does not compute the memory usage correctly when using Xen. It takes the information from /proc/meminfo whose information is not correct (at least for Xen 4.1.2 on Ubuntu). I've spotted the following situations:

 - No memory limit on the dom0. Whenever a machine is spawned, the dom0 memory might be ballooned down, so the memory reported by meminfo is also shrinked. This causes that the memory_mb column in the compute_nodes table changes.

 - Memory limit on the dom0 (i.e dom0_mem option in grub). Meminfo only shows the memory available for the dom0, but will not honour the total memory and the memory that is actually available for the domUs (xm info|grep memory).

I'm currently working on a fix, that I hope will be submitted soon.

Related branches

CVE References

Alvaro Lopez (aloga)
Changed in nova:
assignee: nobody → Alvaro Lopez (aloga)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7296

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/7296
Committed: http://github.com/openstack/nova/commit/5b93a576583d8830fd6636df73d65349017bb617
Submitter: Jenkins
Branch: master

commit 5b93a576583d8830fd6636df73d65349017bb617
Author: Alvaro Lopez Garcia <email address hidden>
Date: Thu May 10 10:30:29 2012 +0200

    Report memory correctly on Xen. Fixes bug 997014

    /proc/meminfo may show wrong values for the memory when using Xen, so
    this fix computes the memory quering libivrt.

    Change-Id: I188e2d34bcee13954653b93b9b816cf4530b8859

Changed in nova:
status: In Progress → Fix Committed
Devin Carlen (devcamcar)
Changed in nova:
milestone: none → folsom-1
importance: Undecided → High
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/essex)

Fix proposed to branch: stable/essex
Review: https://review.openstack.org/7789

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/essex)

Reviewed: https://review.openstack.org/7789
Committed: http://github.com/openstack/nova/commit/84a43e140568c4806c5962b273297439db2a5199
Submitter: Jenkins
Branch: stable/essex

commit 84a43e140568c4806c5962b273297439db2a5199
Author: Alvaro Lopez Garcia <email address hidden>
Date: Thu May 10 10:30:29 2012 +0200

    Report memory correctly on Xen. Fixes bug 997014

    /proc/meminfo may show wrong values for the memory when using Xen, so
    this correctly computes the memory by querying libvirt.

    Change-Id: I188e2d34bcee13954653b93b9b816cf4530b8859

tags: added: in-stable-essex
Revision history for this message
Chuck Short (zulcss) wrote : Re: Memory is not correctly computed for Xen+libvirt

** Impact **

The current code in libvirt/connection.py does not compute the memory usage correctly when using Xen. It takes the information from /proc/meminfo whose information is not correct (at least for Xen 4.1.2 on Ubuntu). I've spotted the following situations:

 - No memory limit on the dom0. Whenever a machine is spawned, the dom0 memory might be ballooned down, so the memory reported by meminfo is also shrinked. This causes that the memory_mb column in the compute_nodes table changes.

 - Memory limit on the dom0 (i.e dom0_mem option in grub). Meminfo only shows the memory available for the dom0, but will not honour the total memory and the memory that is actually available for the domUs (xm info|grep memory).

** DevelopmentF Fix **

This has been addressed in development trunk: https://review.openstack.org/7296 and fixed in quantal.

** Stable Fix **

This has been addressed in stable/essex at: https://review.openstack.org/7789

** Test Case **

None

** Regression Potential **

None

Chuck Short (zulcss)
summary: - Memory is not correctly computed for Xen+libvirt
+ [SRU] Memory is not correctly computed for Xen+libvirt
Chuck Short (zulcss)
Changed in nova (Ubuntu Precise):
milestone: none → ubuntu-12.04.1
assignee: nobody → Chuck Short (zulcss)
Chuck Short (zulcss)
Changed in nova (Ubuntu):
status: New → In Progress
Changed in nova (Ubuntu Precise):
status: New → In Progress
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Alvaro, or anyone else affected,

Accepted nova into precise-proposed. The package will build now and be available in a few hours. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in nova (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Adam Gandelman (gandelman-a) wrote :

Please find the attached Jenkins job results from the Ubuntu Server Team's CI
infrastructure. As part of the verification process for this bug, Nova has
been deployed and configured across multiple nodes using precise-proposed as
an installation source. After successful bring-up and configuration of the
cluster, a number of exercises and smoke tests have be invoked to ensure the
updated package did not introduce any regressions. A number of test iterations
were carried out to catch any possible transient errors.

Note the list of installed packages at the top and bottom of the report.

For records of upstream test coverage of this update, please see the
Jenkins links in the comments of the relevant upstream code-review:

https://review.openstack.org/7789

As per the provisional Micro Release Exception granted to this package by
the Technical Board, we hope this contributes toward verification of this
update.

Dave Walker (davewalker)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nova - 2012.1+stable~20120612-3ee026e-0ubuntu1

---------------
nova (2012.1+stable~20120612-3ee026e-0ubuntu1) precise-proposed; urgency=low

  * New upstream snapshot. (LP: #1010473)
  * Dropped, superseeded by new snapshot:
    - debian/patches/upstream/0001-fix-bug-where-nova-ignores-glance-host-in-imageref.patch
    - debian/patches/upstream/0002-Stop-libvirt-test-from-deleting-instances-dir.patch
    - debian/patches/upstream/0003-Allow-unprivileged-RADOS-users-to-access-rbd-volumes.patch
    - debian/patches/upstream/0004-Fixed-bug-962840-added-a-test-case.patch
    - debian/patches/upstream/0005-Populate-image-properties-with-project_id-again.patch
    - debian/patches/upstream/0006-Use-project_id-in-ec2.cloud._format_image.patc
    - debian/patches/CVE-2012-2101.patch
    - debian/patches/CVE-2012-2654.patch
  * Resynchronize with stable/essex:
    - 3ee026e Only invoke .lower() on non-None protocols. (LP: #1010514)
    - f0a9f47 Create a utf8 version of the dns_domains table. (LP: #993663)
    - 84a43e1 Report memory correctly on Xen. (LP: #997014)
    - 8c72924 Add libvirt get_console_output tests: pty and file. (LP: #990237)
    - 4e423cd Fix Multi_Scheduler to process host capabilities. (LP: #1000403)
    - 4aea7f1 Nail pep8 dependencies to 1.0.1
    - 2b3bbc4 handle updated qemu-img info output. (LP: #1000261)
    - 2d7d51c Fix type of snapshot_id column to match db. (LP: #962615)
    - ec70c69 Generate a Changelog for Nova
    - e5e890f Fix nova.tests.test_nova_rootwrap on Fedora 17. (LP: #992916)
    - 9e9a554 Ec2 handle strings with "0x" (LP: #983206)
    - 26dc6b7 QuantumManager will start dnsmasq during startup. Fixes (LP: #977759)
    - 7028d66 Introduced flag base_dir_name. (LP: #973194)
    - 76b525a Get unit tests functional in OS X.
    - facb936 Update KillFilter to handle 'deleted' exe's. (LP: #967931)
    - 1209af4 Checks if value is string or not before decode. (LP: #952176)
    - 1209af4 Fix timeout in EC2 CloudController.create_image(). (LP: #989764)
    - 108e74b Re-add console_log from console_console_output(). (LP: #987335)
    - 48a0768 Don't leak RPC connections on timeouts or other exceptions. (LP: #968843)
    - 7c64de9 Cloudpipe tap vpn not always working. (LP: #975043)
    - 5ab5051 add libvirt_inject_key flag fix (LP: #971640)
    - 6c68ef5 Xen: Pass session to destroy_vdi. (LP: #988615)
    - 015744e Delete fixed_ips when network is deleted. (LP: #754900)
  * Add debian/scripts/changelog.sh to help generate the changelog.
  * Add debian/nova-common.docs:
    - Include changelog and README.rst
  * debian/rules: Generate a tarball from git snapshot.
  * debian/patches/fix-pep8-errors.patch: Fix pep8 errors due to pep8 upstream
    migration.
 -- Chuck Short <email address hidden> Tue, 05 Jun 2012 09:50:59 -0400

Changed in nova (Ubuntu Precise):
status: Fix Committed → Fix Released
Chuck Short (zulcss)
Changed in nova (Ubuntu):
status: In Progress → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-1 → 2012.2
Revision history for this message
Johann Evans (dreamweaver360-deactivatedaccount) wrote :

This also affects CentOS release on Newton

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.