Landscape Client

Remove smart-specific methods from AptFacade

Bug #996841 reported by Björn Tillenius
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Landscape Client
Fix Released
Medium
Björn Tillenius
Landscape Client 12.05

Bug Description

We have some methods on AptFacade that are there only because SmartFacade had them. Now that SmartFacade is gone, we should remove those methods.

Related branches

lp:~bjornt/landscape-client/remove-smart-methods
Alberto Donato (community): Approve
Mike Milner (community): Approve
Diff: 532 lines (+33/-285)
7 files modified
landscape/package/changer.py (+8/-29)
landscape/package/facade.py (+0/-16)
landscape/package/reporter.py (+4/-55)
landscape/package/store.py (+0/-37)
landscape/package/tests/test_changer.py (+4/-9)
landscape/package/tests/test_reporter.py (+14/-36)
landscape/package/tests/test_store.py (+3/-103)
lp:~landscape/landscape-client/landscape-client-12.05-0ubuntu1-quantal
lp:ubuntu/vivid/landscape-client
lp:ubuntu/lucid-proposed/landscape-client
lp:ubuntu/natty-proposed/landscape-client
lp:ubuntu/oneiric-proposed/landscape-client
lp:ubuntu/precise-proposed/landscape-client
Björn Tillenius (bjornt)
Changed in landscape-client:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Björn Tillenius (bjornt)
milestone: none → 12.05
tags: added: theme-tech-debt
Björn Tillenius (bjornt)
Changed in landscape-client:
status: In Progress → Fix Committed
Andreas Hasenack (ahasenack)
Changed in landscape-client:
milestone: 12.05 → 12.06
Dean Henrichsmeyer (dean)
Changed in landscape-client:
milestone: 12.06 → 12.05
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

qa + 1

Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello Björn, or anyone else affected,

Accepted landscape-client into natty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/landscape-client/12.05-0ubuntu0.11.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hello Björn, or anyone else affected,

Accepted landscape-client into lucid-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/landscape-client/12.05-0ubuntu0.10.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hello Björn, or anyone else affected,

Accepted landscape-client into oneiric-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/landscape-client/12.05-0ubuntu0.11.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hello Björn, or anyone else affected,

Accepted landscape-client into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/landscape-client/12.05-0ubuntu0.12.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Verified for precise:

root@domU-12-31-39-07-65-39:~# lsb_release -cs
precise

root@domU-12-31-39-07-65-39:~# dpkg -L landscape-common|grep reporter
/usr/share/pyshared/landscape/package/reporter.py
/usr/lib/python2.7/dist-packages/landscape/package/reporter.py

root@domU-12-31-39-07-65-39:~# grep SmartFacade /usr/share/pyshared/landscape/*

root@domU-12-31-39-07-65-39:~# apt-cache policy landscape-client
landscape-client:
  Installed: 12.05-0ubuntu0.12.04
  Candidate: 12.05-0ubuntu0.12.04
  Version table:
 *** 12.05-0ubuntu0.12.04 0
        500 http://archive.ubuntu.com/ubuntu/ precise-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     12.04.3-0ubuntu1 0
        500 http://us-east-1.ec2.archive.ubuntu.com/ubuntu/ precise/main i386 Packages
root@domU-12-31-39-07-65-39:~#

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Verified on oneiric:

root@ip-10-204-113-249:~# lsb_release -cs
oneiric
root@ip-10-204-113-249:~# dpkg -L landscape-common|grep reporter
/usr/share/pyshared/landscape/package/reporter.py
/usr/lib/python2.7/dist-packages/landscape/package/reporter.py
root@ip-10-204-113-249:~# grep SmartFacade /usr/share/pyshared/landscape/package/*
root@ip-10-204-113-249:~# apt-cache policy landscape-common
landscape-common:
  Installed: 12.05-0ubuntu0.11.10
  Candidate: 12.05-0ubuntu0.11.10
  Version table:
 *** 12.05-0ubuntu0.11.10 0
        500 http://archive.ubuntu.com/ubuntu/ oneiric-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     12.04.3-0ubuntu0.11.10 0
        500 http://us-east-1.ec2.archive.ubuntu.com/ubuntu/ oneiric-updates/main i386 Packages
     11.07.1.1-0ubuntu1.11.10.0 0
        500 http://us-east-1.ec2.archive.ubuntu.com/ubuntu/ oneiric/main i386 Packages
root@ip-10-204-113-249:~#

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Verified on natty:

root@ip-10-194-79-50:~# lsb_release -cs
natty
root@ip-10-194-79-50:~# dpkg -L landscape-common|grep reporter
/usr/share/pyshared/landscape/package/reporter.py
/usr/lib/python2.7/dist-packages/landscape/package/reporter.py
root@ip-10-194-79-50:~# grep SmartFacade /usr/share/pyshared/landscape/package/*
root@ip-10-194-79-50:~# apt-cache policy landscape-common
landscape-common:
  Installed: 12.05-0ubuntu0.11.04
  Candidate: 12.05-0ubuntu0.11.04
  Version table:
 *** 12.05-0ubuntu0.11.04 0
        500 http://archive.ubuntu.com/ubuntu/ natty-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     12.04.3-0ubuntu0.11.04 0
        500 http://us-east-1.ec2.archive.ubuntu.com/ubuntu/ natty-updates/main i386 Packages
     11.02-0ubuntu0.11.04.1 0
        500 http://us-east-1.ec2.archive.ubuntu.com/ubuntu/ natty/main i386 Packages

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Verified on lucid:

root@ip-10-28-223-162:~# lsb_release -cs
lucid
root@ip-10-28-223-162:~# dpkg -L landscape-common|grep reporter
/usr/share/pyshared/landscape/package/reporter.py
/usr/lib/python2.6/dist-packages/landscape/package/reporter.py
root@ip-10-28-223-162:~# grep SmartFacade /usr/share/pyshared/landscape/package/*
root@ip-10-28-223-162:~# apt-cache policy landscape-common
landscape-common:
  Installed: 12.05-0ubuntu0.10.04
  Candidate: 12.05-0ubuntu0.10.04
  Version table:
 *** 12.05-0ubuntu0.10.04 0
        500 http://archive.ubuntu.com/ubuntu/ lucid-proposed/main Packages
        100 /var/lib/dpkg/status
     12.04.3-0ubuntu0.10.04 0
        500 http://us-east-1.ec2.archive.ubuntu.com/ubuntu/ lucid-updates/main Packages
     1.5.0.1-0ubuntu0.10.04.0 0
        500 http://us-east-1.ec2.archive.ubuntu.com/ubuntu/ lucid/main Packages

Sebastien Bacher (seb128)
tags: added: verification-done
removed: verification-needed
Andreas Hasenack (ahasenack)
Changed in landscape-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.